[Bug 272246] shells/fish: please add upstream patch that fixes zfs tab completion

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272246

            Bug ID: 272246
           Summary: shells/fish: please add upstream patch that fixes zfs
                    tab completion
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: asomers@FreeBSD.org
          Reporter: dch@freebsd.org
             Flags: maintainer-feedback?(asomers@FreeBSD.org)
          Assignee: asomers@FreeBSD.org

3.6.1 broke zfs tabcompletion.

This straightforward patch (which will end up in 3.6.2) fixes it:

curl -so -
https://github.com/fish-shell/fish-shell/commit/85504ca694ae099f023ae0febb363238d9c64e8d.diff
| doas patch -p3


error without this patch:

> zfs lsitread: _: cannot overwrite read-only variable
/usr/local/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 12):
    echo $feature_name | read -l _ _ state _
    ^
in function '__fish_is_zfs_feature_enabled' with arguments 'feature@bookmarks'
        called on line 344 of file /usr/local/share/fish/completions/zfs.fish
from sourcing file /usr/local/share/fish/completions/zfs.fish

(Type 'help read' for related documentation)
read: _: cannot overwrite read-only variable
/usr/local/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 12):
    echo $feature_name | read -l _ _ state _
    ^
in function '__fish_is_zfs_feature_enabled' with arguments 'feature@bookmarks'
        called on line 508 of file /usr/local/share/fish/completions/zfs.fish
from sourcing file /usr/local/share/fish/completions/zfs.fish

(Type 'help read' for related documentation)
read: _: cannot overwrite read-only variable
/usr/local/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 12):
    echo $feature_name | read -l _ _ state _
    ^
in function '__fish_is_zfs_feature_enabled' with arguments
'feature@extensible_dataset'
        called on line 548 of file /usr/local/share/fish/completions/zfs.fish
from sourcing file /usr/local/share/fish/completions/zfs.fish

(Type 'help read' for related documentation)

-- 
You are receiving this mail because:
You are the assignee for the bug.