From nobody Sun Jun 25 17:26:36 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QpyZP4v5Fz4hNhb for ; Sun, 25 Jun 2023 17:26:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QpyZN4TpNz4NQS for ; Sun, 25 Jun 2023 17:26:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687713996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kpKkbd482NICW86emF+Ih0NEOHFhBW330blA1McZB+w=; b=fwuQGUMBmMoXPpMfS64vyjShvw1REfCTB3aERuRNkRwt70auOnkz2ysvb/WWVqcSRrrfqL 1iHW74G2qlH64k5bcbApro5WfKji8doyiCvUqR4BWw64TKbznWpBA18+D0H4de+fK85QsO HUWf55hkgVR1wcO9VaUxo8sfxA6kgN51ho+I5+8aB0v9mudvUImq2Ft8zcseKtmVLtOoOn YkFrVG/eCI3Zr+32o8BXNA2+UMq6nSHjkUKcZ9a4IgBSy+t0E3Niu8eXF3n9I6k7/Yyne1 htQiKo8DJyGNw/YtV6C6kHLgXcK/YYeGxxLougezFD1xkChpJMnwAiRA4AmuRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687713996; a=rsa-sha256; cv=none; b=VjeZ41T7I1vF0+tKwlBtKbmOriiAGnQSyDMaw1U6LXLtqVhOu3uzAyyi43pxS6scxNRM/y TbWWO7RV4xWiyaNe0IylvYJ+4tNDfUieYMBqNXNTy4kpU+LBS7sHRdXKaMIxU+KWlcwPBE r3UE+LwkdFtFU953hc7QSxXIZzEGhK0GofwrOC7h0O7l07AP/p4pPRUXodAAPPVJjsCQXj tA7YrAbWVoCaDw01xPOzdmIV15gqVF1PS90J6maQS4QGREjWSC4cgkPOdJbtFItqaLQQxn zQXYuDcvlZJegQYs61zzB2V1i4cGTLmQPyz82vgXVu1ibhcv98e6Gw3tYDHPGg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QpyZN3PjvzbZ2 for ; Sun, 25 Jun 2023 17:26:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35PHQaZd051699 for ; Sun, 25 Jun 2023 17:26:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35PHQaPY051698 for ports-bugs@FreeBSD.org; Sun, 25 Jun 2023 17:26:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 272054] [NEW PORT] sysutils/gh-md-toc: Easy TOC creation for GitHub README.md Date: Sun, 25 Jun 2023 17:26:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272054 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org --- Comment #1 from Robert Clausecker --- Thank you for your submission. Here are some comments: - does this script run with /bin/sh? If yes, we could eliminate the bash dependency. - could you patch the script to use fetch(1) instead of wget(1) or curl(1)? This would permit elimination of these dependencies. - please only use ${PORTNAME} if the makefile would still work was PORTNAME changed. In this case, if the port is renamed, the do-install target no longer works, so perhaps you shouldn't use PORTNAME there. - using ${PORTDOCS[0]} to get the name of a known file is fragile programm= ing style. What if PORTDOCS has multiple entries and someone sorts it so RE= ADME is no longer the first entry? Try to avoid such dependencies on element order in lists. Just hardcode README as the file you want to install. - WWW does not need a trailing slash. Will proceed with a build test once these issues have been addressed. --=20 You are receiving this mail because: You are the assignee for the bug.=