[Bug 269754] multimedia/jellyfin: Add port with jellyfish combined version 10.8.9
Date: Fri, 24 Feb 2023 23:39:06 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269754
Robert Clausecker <fuz@FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
CC| |fuz@FreeBSD.org
Assignee|ports-bugs@FreeBSD.org |fuz@FreeBSD.org
--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Review:
- I see that you bundle libSkiaSharp.so as a binary file (o.O) Could you
check
if this file can be unbundled or built from source?
- LICENSE_COMB=dual means that either of the licenses can be used. Is this
correct? If multiple licenses apply at the same time, please use
LICENSE_COMB=multi
- consider replacing amd64 with ${ARCH} in distfiles to ensure that the port
break in an obvious place when compilation on another architecture is tried
- you seem to replace jellyfin with ${PORTNAME} in lots of places. I
recommend
only using ${PORTNAME} in places where changing the PORTNAME would not break
the build. Just because it's the string jellyfin doesn't mean that it is
${PORTNAME}.
- why is the one file in PLIST_FILES instead of in pkg-plist?
--
You are receiving this mail because:
You are the assignee for the bug.