[Bug 269583] audio/festival: Segmentation fault
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 269583] festival is not working"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 21 Feb 2023 07:26:24 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269583 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=39e57d44aa5af331426f14f1a54c07d6912a7b91 commit 39e57d44aa5af331426f14f1a54c07d6912a7b91 Author: Mikhail Teterin <mi@FreeBSD.org> AuthorDate: 2023-02-21 07:23:22 +0000 Commit: Mikhail Teterin <mi@FreeBSD.org> CommitDate: 2023-02-21 07:23:22 +0000 audio/festival: fix crash due to overly aggressive optimization Modern clang, optimize away checks like "if (this == NULL)", which are, indeed, redundant in good C++ code. Unfortunately, festival's code is not too good, and the checks are essential... PR: 269583 While here, eliminate some of the other warnings raised by both compiler and valgrind, and adapt one more patch from Debian. Bump PORTREVISION. audio/festival/Makefile | 8 +- .../files/patch-hts-buffer-bounds-check (new) | 313 +++++++++++++++++++++ audio/festival/files/patch-warnings (new) | 76 +++++ 3 files changed, 393 insertions(+), 4 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.