[Bug 269443] sysutils/jdupes: Update to 1.21.3

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269443

--- Comment #11 from Thomas Hurst <tom@hur.st> ---
(In reply to Fernando Apesteguía from comment #10)

Yes, building with ports and directly is going to have different flags, and
both trigger the problem.  My flags within poudriere are identical to yours,
aside from yours not having the low-memory settings?

cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wwrite-strings -Wcast-align -Wstrict-aliasing
-Wstrict-prototypes -Wpointer-arith -Wundef -Wshadow -Wfloat-equal
-Waggregate-return -Wcast-qual -Wswitch-default -Wswitch-enum -Wconversion
-Wunreachable-code -Wformat=2 -std=gnu99 -D_FILE_OFFSET_BITS=64
-fstrict-aliasing -pipe -DSMA_MAX_FREE=11 -DNO_ATIME -Wextra
-Wstrict-overflow=5 -Winit-self -DNDEBUG -Wl,-z,stack-size=16777216
-DLOW_MEMORY -DSMA_PAGE_SIZE=32768 -DNO_HARDLINKS -DNO_SYMLINKS -DNO_USER_ORDER
-DNO_PERMS -DNO_ATIME -DNO_JSON -DNO_EXTFILTER -DNO_CHUNKSIZE -DUSE_JODY_HASH
-DNO_NUMSORT -DCHUNK_SIZE=16384  -isystem /usr/local/include  -c -o jdupes.o
jdupes.c

If yours is somehow not built with LOW_MEMORY despite the config option being
set, that would explain why it isn't crashing for you, but raises further
questions!

> One question would be, why would you want to strip an executable that has been compiled with debug info (-g). At least in the porter's handbook we say "When WITH_DEBUG is defined, elf files must not be stripped."

-g just happens to be what's specified in the upstream source.  I patch it out
in the port so it's under the control of the framework.

> Do you have WITH_DEBUG in make.conf?

No, I just have a few targeted WITH_DEBUG_PORTS.  The port builds fine if I add
it.

> As a workaround, I think we could add a build dependency on devel/binutils and then overwrite ${STRIP_CMD}.

Either that, or just clobber STRIP_CMD and let it be installed unstripped.  It
seems kind of counterproductive - particularly to anyone building their own
ports - to build and install the whole of binutils for the sake of reducing the
installed LOW_MEMORY executable from 48k to 33k.

Either way, I think it's time to open a new issue against base.

-- 
You are receiving this mail because:
You are the assignee for the bug.