[Bug 269114] irc/pounce: missing pkgconfig dependency

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269114

--- Comment #4 from Fernando Apesteguía <fernape@FreeBSD.org> ---
(In reply to Tassilo Philipp from comment #3)
I think the test is not right.

The port is not using the "configure" script provided by upstream that is in
turn the only consumer of the pkg-config utility since in the port's Makefile
there is no HAS_CONFIGURE or GNU_CONFIGURE.

Maybe it should, maybe it shouldn't, but the fact is that it seems to call just
"make" with the arguments passed in MAKE_ENV.

So while upstream provides a "configure" executable script that uses
pkg-config, when building from the ports infrastructure, that script is not
used.

As a test, from a jail in which I successfully built irc/pounce with poudriere,
I just did a "make extract", then removed the configure script from the work
directory and then typed "make" and the port's Makefile, doesn't us it
(otherwise it would fail):

root@13_1amd64-default:/usr/ports/irc/pounce # make extract
===>  License GPLv3+ accepted by the user
===>   pounce-3.0_3 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by pounce-3.0_3 for building
===>  Extracting for pounce-3.0_3
=> SHA256 Checksum OK for pounce-3.0.tar.gz.
root@13_1amd64-default:/usr/ports/irc/pounce # rm
/wrkdirs/usr/ports/irc/pounce/work/pounce-3.0/configure
root@13_1amd64-default:/usr/ports/irc/pounce # make
===>  Patching for pounce-3.0_3
===>   pounce-3.0_3 depends on file: /usr/local/bin/ccache - found
===>   pounce-3.0_3 depends on shared library: libtls.so - found
(/usr/local/lib/libtls.so)
===>  Configuring for pounce-3.0_3
===>  Building for pounce-3.0_3
--- dispatch.o ---
--- bounce.o ---
--- client.o ---
--- config.o ---
--- local.o ---
--- ring.o ---
--- server.o ---
--- state.o ---
--- xdg.o ---
--- dispatch.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c dispatch.c -o dispatch.o
--- bounce.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c bounce.c -o bounce.o
--- client.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c client.c -o client.o
--- config.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c config.c -o config.o
--- local.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c local.c -o local.o
--- ring.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c ring.c -o ring.o
--- state.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c state.c -o state.o
--- server.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c server.c -o server.o
--- xdg.o ---
cc  -O2 -pipe  -D'OPENSSL_BIN="/usr/bin/openssl"' -fstack-protector-strong
-isystem /usr/local/include -fno-strict-aliasing  -std=c11 -Wall -Wextra
-Wpedantic -c xdg.c -o xdg.o
--- calico ---
cc   -fstack-protector-strong -L/usr/local/lib  dispatch.o  -o calico
--- pounce ---
cc   -fstack-protector-strong -L/usr/local/lib  bounce.o client.o config.o
local.o ring.o server.o state.o xdg.o -lcrypt -ltls -o pounce
===>  Staging for pounce-3.0_3
===>   Generating temporary packing list
install -d /wrkdirs/usr/ports/irc/pounce/work/stage/usr/local/bin
/wrkdirs/usr/ports/irc/pounce/work/stage/usr/local/man/man1
install calico pounce /wrkdirs/usr/ports/irc/pounce/work/stage/usr/local/bin
install -m 644 calico.1 pounce.1
/wrkdirs/usr/ports/irc/pounce/work/stage/usr/local/man/man1
/usr/bin/strip /wrkdirs/usr/ports/irc/pounce/work/stage/usr/local/bin/calico
/usr/bin/strip /wrkdirs/usr/ports/irc/pounce/work/stage/usr/local/bin/pounce
====> Compressing man pages (compress-man)
===> Staging rc.d startup script(s)
root@13_1amd64-default:/usr/ports/irc/pounce # 
root@13_1amd64-default:/usr/ports/irc/pounce # ls
/wrkdirs/usr/ports/irc/pounce/work/pounce-3.0/confi*
/wrkdirs/usr/ports/irc/pounce/work/pounce-3.0/config.c 
/wrkdirs/usr/ports/irc/pounce/work/pounce-3.0/config.o

-- 
You are receiving this mail because:
You are the assignee for the bug.