From nobody Fri Dec 29 20:35:34 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1xw70Yjxz559X9 for ; Fri, 29 Dec 2023 20:35:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1xw658xZz3VdP for ; Fri, 29 Dec 2023 20:35:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703882134; a=rsa-sha256; cv=none; b=O+74b5/Jme22fnapysmtLQP8WlcebIgLFyvxT2YEkUgeuiEZg0cRl1W/ASrZEpme+BBlSb 5+F0W4FY/vvNuPU8IvnRwNnTqgidKuGh8yfsHvVhZFtoMfhb38VJVBV8tSish0FB5QWDUu rIgQ7SA1FVjih1Ni45/L+QqmV0V1L10sgqFN7QSP2/kNgwbeSF45VXqhTxCPCXZX4KDb6/ Mo/xt2ddu4dRWDKqFmtNZ5ddd+w/q0EFVNuCHQ7hbHwm8BPOulW3iuZ3980Z4WbV0mqG7G Yp0VmvF7U0bzJKxXrnfpHvCPJJi30qyHvHoLJF2zw+dWhrqi/DKnbVYZhJnAXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703882134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzgHi/E0F8bMZvy61shooXOf80lOHfqSJmYzyyAtQqk=; b=HJDtq2cXgMYhvJah0qtBKhJRWAtMcNy087XzbWVTv1Ce0iwIYslOh7WUytQ1CqmfkXSX39 f3fz/hLC29JWTBdhFI0lFMX1GqOp/YfcfJe10EJkBvFtXjHqcM2tF8J7iGkjc1cM95z0rN +RUPvBdc7kYszhvgTOYNaICkSx/1+cpV7MIJTM26PM0pAXSNSNo8xHSEq+v4f4tGvp83Nd RCSSDSam+eFskZkaGWcnD5syFpzBNqr7kuU4mJpZodNLpY7CERtTuMNHMChSkUstqAeFs6 UJjVHxuskyFV4VcnLv6j2bwL0rZ601MDoD6rJutRwSNkNV/wlwg1L36WRdtV8g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T1xw64DwBz5rT for ; Fri, 29 Dec 2023 20:35:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BTKZYDe039286 for ; Fri, 29 Dec 2023 20:35:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BTKZYaI039285 for ports-bugs@FreeBSD.org; Fri, 29 Dec 2023 20:35:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 276001] sysutils/slurm-wlm: slurmctld fails to start Date: Fri, 29 Dec 2023 20:35:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jwb@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276001 --- Comment #1 from Jason W. Bacon --- The patches below resolve the invalid argument errors on startup, though th= ere may be other bind() calls that need fixing. There are also issues with slu= rmd trying to start the cgroups plugin. diff -ruN --exclude=3DCVS --exclude=3D.svn /usr/ports/sysutils/slurm-wlm/files/patch-src_common_net.c /usr/ports/wip/slurm-wlm-devel/files/patch-src_common_net.c --- /usr/ports/sysutils/slurm-wlm/files/patch-src_common_net.c 1969-12-31 18:00:00.000000000 -0600 +++ /usr/ports/wip/slurm-wlm-devel/files/patch-src_common_net.c 2023-12-29 14:26:37.856355000 -0600 @@ -0,0 +1,25 @@ +--- src/common/net.c.orig 2023-12-29 19:19:05 UTC ++++ src/common/net.c +@@ -90,11 +90,12 @@ strong_alias(net_stream_listen,=20=20=20=20=20=20=20= =20=20=20=20 slurm_net_stream_list + int net_stream_listen(int *fd, uint16_t *port) + { + slurm_addr_t sin; +- socklen_t len =3D sizeof(sin); ++ socklen_t len; + int val =3D 1; +=20 + /* bind ephemeral port */ + slurm_setup_addr(&sin, 0); ++ len =3D sin.ss_len; +=20 + if ((*fd =3D socket(sin.ss_family, SOCK_STREAM, IPPROTO_TCP)) < 0) + return -1; +@@ -219,7 +220,7 @@ static bool _is_port_ok(int s, uint16_t port, bool loc + return false; + } +=20 +- if (bind(s, (struct sockaddr *) &addr, sizeof(addr)) < 0) { ++ if (bind(s, (struct sockaddr *) &addr, addr.ss_len) < 0) { + log_flag(NET, "%s: bind() failed on port:%d fd:%d: %m", + __func__, port, s); + return false; diff -ruN --exclude=3DCVS --exclude=3D.svn /usr/ports/sysutils/slurm-wlm/files/patch-src_common_slurm__protocol__socke= t.c /usr/ports/wip/slurm-wlm-devel/files/patch-src_common_slurm__protocol__sock= et.c --- /usr/ports/sysutils/slurm-wlm/files/patch-src_common_slurm__protocol__socke= t.c=20 1969-12-31 18:00:00.000000000 -0600 +++ /usr/ports/wip/slurm-wlm-devel/files/patch-src_common_slurm__protocol__sock= et.c 2023-12-29 14:26:37.856433000 -0600 @@ -0,0 +1,20 @@ +--- src/common/slurm_protocol_socket.c.orig 2023-12-29 19:26:12 UTC ++++ src/common/slurm_protocol_socket.c +@@ -116,7 +116,7 @@ static void _sock_bind_wild(int sockfd) + slurm_setup_addr(&sin, RANDOM_USER_PORT); +=20 + for (retry=3D0; retry < PORT_RETRIES ; retry++) { +- rc =3D bind(sockfd, (struct sockaddr *) &sin, sizeof(sin)); ++ rc =3D bind(sockfd, (struct sockaddr *) &sin, sin.ss_len); + if (rc >=3D 0) + break; + slurm_set_port(&sin, RANDOM_USER_PORT); +@@ -511,7 +511,7 @@ extern int slurm_init_msg_engine(slurm_addr_t *addr, b + goto error; + } +=20 +- rc =3D bind(fd, (struct sockaddr const *) addr, sizeof(*addr)); ++ rc =3D bind(fd, (struct sockaddr const *) addr, addr->ss_len); + if (rc < 0) { + format_print(log_lvl, "Error binding slurm stream socket: %= m"); + goto error; --=20 You are receiving this mail because: You are the assignee for the bug.=