[Bug 273257] net-mgmt/victoria-metrics: doesn't report proper version

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273257

            Bug ID: 273257
           Summary: net-mgmt/victoria-metrics: doesn't report proper
                    version
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: danfe@FreeBSD.org
          Reporter: lapo@lapo.it
             Flags: maintainer-feedback?(danfe@FreeBSD.org)
          Assignee: danfe@FreeBSD.org

These are metrics I receive from some of my vmagents:

vm_app_version{instance="…", job="vmagent",
version="vmagent-20230313-062416-16be82b"}
vm_app_version{instance="…", job="vmagent",
version="vmagent-20230407-010449-tags-v1.90.0-0-gb5d18c0d2",
short_version="v1.90.0"}
vm_app_version{instance="…", job="victoria-metrics",
version="victoria-metrics-20230816-130821-tags-v1.93.0-0-g59f7d810c",
short_version="v1.93.0"}

("version" doesn't have tag info, and "short_version" is missing altogether)

The first comes from the Ports (not the most recent, but it's the same), the
second is a Windows build, the third is running on FreeBSD but compiled
manually (git clone + gmake).

I wonder / I guess it would be enough to use a build tag like this in the
Makefile:

BUILDINFO_TAG=tags-v1.93.0-0-g59f7d810c

Ah, yes, I checked with a local build and it seems to be enough:

vm_app_version{version="vmagent-20230812-130110-tags-v1.93.0-0-g59f7d810c",
short_version="v1.93.0"}

I can produce a patch if desired, but I simply changed PORTVERSION,
BUILDINFO_TAG, make gomod-vendor, make makesum, make install.

PS: 1.93 is the new LTS after 1.87.

-- 
You are receiving this mail because:
You are the assignee for the bug.