From nobody Wed Aug 09 13:37:48 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RLWMd0X82z4q0Vg for ; Wed, 9 Aug 2023 13:37:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RLWMc5SsLz4Q78 for ; Wed, 9 Aug 2023 13:37:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691588268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3v8qYpptiIPTdhDhaBZXWlvUP3wc2JxeKsYOhOArKPI=; b=we20NZEb2rdICkHrOV/doGireHntwwJ21zHAtHES87flT8JWpARNagTSOqcBlmY6xwnUzs lXqA0o6uofphehaBfv5q3Ov1NtUvwWq4sXIXw7at+o+RtY19/Sc13zFL9/1kYlLnYJqNAg T8ER9jMFgj0fRvKavRayVO3ah9jm3k27TA6+jdbxvNmWXsjiG6TaOWggO5TrNKNCDVlFZT S1PJen2lYlykxboLbX16CkcjgpSEsQxGU5EuiC48LXONcWYVV4rl5rVCt+CQ3T4mIuHd7P 8+LLTOAWNfmQn8ZHzswegI+kUQ9MQeXnSElAkX1wJlw8vxouCc93uWuRSbmLYQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691588268; a=rsa-sha256; cv=none; b=guSNt4Ooir+WaVgMfeT5hcp0YOMO8fW1s8qUShg1tuxOF/zh2r52kVRh4GvInsTfK9SSsT KGjGQI5/H7jyE18FeEs4qfW0hen+Xj5V/MzHFJyLlm25zg6w+C2wA8C8ARm/kdDKms6m3F i7FdeFBoh/3j7WZmi7lWm/N/BKVAyMwJfKzr3agVvnS+QqRrUCFyBQIlGqhIX1lgt4TD7X /FM8OvnAW9M9YbFD7I7Mlwc+cyYZ8Fs4IFhBD3rEdPACROGAkoeSjdQZYyLo9hG1d5Z3qH TAXg+E57qFsjXoZFL4Y30yGaHiERcmlDcZx9Bb8BUH3w9TMl+k7PVUorcPP4fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RLWMc4YQ4z2n2 for ; Wed, 9 Aug 2023 13:37:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 379Dbmeo040949 for ; Wed, 9 Aug 2023 13:37:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 379DbmrI040948 for ports-bugs@FreeBSD.org; Wed, 9 Aug 2023 13:37:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 272312] [NEW PORT] security/p5-openxpki-clca: Toolkit for root CA Date: Wed, 09 Aug 2023 13:37:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272312 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org Status|New |Open --- Comment #1 from Robert Clausecker --- Thank you for your submission. Contrary to what I said in my email, this submission is not ready to be committed. Some issues for you to check: - You seem to be doing a bunch of rote replacements in an unconventional w= ay. Check if you can use USES=3Dshebangfix instead - if not, I recommend writing a patch file that replaces all instances of = the token you want to replace with some easy to see token. Then use REINPLACE_CMD to fix all instances of this token. For example, replace openssl with %%OPENSSL%% in a patch file, then ${REINPLACE_CMD} -e s,%%OPENSSL%%,${something} to fix this up. This simplifies the whole th= ing to ${FIND} ${some_dir} -exec ${REINPLACE_CMD} -e ... {} + - I recommend moving ${REINPLACE_CMD} use to pre-configure as to not break make makepatch - in any way, do not delete the .bak files as these are used by stage-qa to check for misuse of REINPLACE_CMD - use ${PERL} instead of hardcoding ${PREFIX}/bin/perl - do not assume the port directory is writable. Put temporarily files like filelist into ${WRKDIR} - your pkg-plist does not install anything unless EXAMPLES are selected. Is this correct? - do not define dummy do-build or do-install targets. If you don't need t= hese targets, define NO_BUILD=3Dyes or NO_INSTALL=3Dyes as appropriate. - your installation message recommends that the user copies all these file= s to his or her home directory. Why is this needed? Can't you install the scripts and files into standard locations so they can be used from where they ar= e? We want ports to be usable as they are. Ports are not just a vehicle to download a bunch of files to the users computer. --=20 You are receiving this mail because: You are the assignee for the bug.=