[Bug 270989] print/ghostscript10: adds libgs.so; connects to USES and DEFAULT_VERSIONS facilities; flavorized

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 270989] print/ghostscript10: adds libgs.sol; connects to USES and DEFAULT_VERSIONS facilities; flavorized"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 22 Apr 2023 12:01:53 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270989

--- Comment #2 from Daniel Engberg <diizzy@FreeBSD.org> ---
Thanks for the patch, looks good overall but I have a few inputs having a quick
look at it.

Changes to Mk/Uses/ghostscript.mk should go into a separate patch
PORTVERSION --> DISTVERSION

For overall consistency in tree I'd suggest that we make a nox11 variant rather
than x11 and remove base from naming

Use ".if ${FLAVOR} == nox11" instead of .if !empty(FLAVOR:Mx11)

L104 and L105 is a way to do it but I think for the sake of readability its
better to wrap it around .if statements

-- 
You are receiving this mail because:
You are the assignee for the bug.