[Bug 262318] [NEW PORT] lang/freebasic

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 19 Apr 2023 15:54:42 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262318

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  I apologise that it was not looked at earlier. 
You didn't set maintainer-approval to "+" on your patch, so it didn't get
sorted into the right queue.

Here is some feedback for you:

 - Please remove the "# created by" line.  We have removed them from all ports
   recently.  They will not come back.

 - Please shorten COMMENT to 50 characters or less.

 - Please use DISTVERSION instead of PORTVERSION if possible.

 - it should not be needed to set WRKSRC

 - do not hardcode gmake as the name of the make program.  Instead use ${MAKE}.
   If you have USES=gmake, this expands to the right thing.

 - the GCC option doesn't seem to do anything.  Not sure what you try to
achieve
   by having "PORT_OPTIONS:MGCC" as a line in the port.

 - neither does the DOCS option do anything.  What do you intend it to do?

 - instead of ${PWD}/files, use ${FILESDIR}

 - install files with ${INSTALL_DATA}, ${INSTALL_SHARE}, ... instead of ${CP}
   as appropriate

 - instead of ${SED} -i '' use ${REINPLACE_CMD}

 - the command "${CP} ${WRKSRC}/bin/fbc ${PREFIX}/bin/fbc" in pre-build appears
   to be nonsensical and will fail (you can't write to /usr/local/bin during
the
   build).  What are you trying to achieve?

The port doesn't build for me:

===>  Building for freebasic-1.09.0
gmake[2]: Entering directory
'/usr/home/fuz.ports/lang/freebasic/work/FreeBASIC-1.09.0-source-bootstrap'
mkdir -p src/gfxlib2/obj/freebsd-arm
CC src/gfxlib2/obj/freebsd-arm/gfx_access.o
/bin/sh: gcc: not found
gmake[2]: *** [makefile:855: src/gfxlib2/obj/freebsd-arm/gfx_access.o] Error
127
gmake[2]: Leaving directory
'/usr/home/fuz.ports/lang/freebasic/work/FreeBASIC-1.09.0-source-bootstrap'
*** Error code 2

Stop.

Please check and resubmit.  Feel free to ask any questions you might have.  You
may join us in #freebsd-ports on libera.chat if you need some more assistance.

-- 
You are receiving this mail because:
You are the assignee for the bug.