From nobody Wed Sep 28 22:22:31 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Md9wR3QdBz4VCNx for ; Wed, 28 Sep 2022 22:22:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Md9wR1Rncz3MQ2 for ; Wed, 28 Sep 2022 22:22:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Md9wR0W9rzcVc for ; Wed, 28 Sep 2022 22:22:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 28SMMVxo023794 for ; Wed, 28 Sep 2022 22:22:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 28SMMVgq023793 for ports-bugs@FreeBSD.org; Wed, 28 Sep 2022 22:22:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 266694] emulators/open-vm-tools rc script produces extraneous output, breaks puppet Date: Wed, 28 Sep 2022 22:22:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ray@bellis.me.uk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: garga@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664403751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w4uClJunCrA1GuxIysPBixU9tGzaooOEWdsquZwddrw=; b=nusl6FkR+cqgxfpZGq1/13XIWWiwU4Yelc3N9CMv/kZsOienjo4BlgsiYJ3fRWWbxzinNm b+nzwx6reyH47IFEJyyXtFW1DtyUIivu7/eV1RBIW572iDi+qkW6/nIVBDJlgNvxmhCDns rVBH4anEZ9oFBdlYPld40q+BbaSIw3gKsYyiRoN7yOBgyyVqraVqlR21Cbc+gMt0yRDPJK RYW+Nyr0e0M7vSUFFVXXWZ1wir4noNa87EoGZ5XgqOehweIGfyLLkWL3oFLdyFkNEiG369 zjk+Ai2xj2+6mqfc01cWaXeCa+9/RbqxBzAkNYFvnd3qTElU1R15iy6hLAQYKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664403751; a=rsa-sha256; cv=none; b=xhhGh/fU0QOCpO04ddEpKPLw9lhgX6poo27cFk1GdxyKkbqyfpB21Jzymy3Yob5hVNfmAc ohDQJONdH5OKpEPt7MOpg9mqR2uLg0kQN0N8z+QYz3tcCBGGoqEx1PE5V9J8fOuLqzZFKO 4OUf6EFRfxTYWg+FWWwu+2jh+o/MziyITUbZR7Z7n0vOmWLlW//MMyE9n1iZUXicxzVlLf WXicGfk81pUzceeuRxkGx7sWPyHNjxuOR+pXmdRIIQbHbx+VoM6qQniANfVsLv3WE8ok9K 37spb/qhWOPFgtzEgRXr+mU47l2VK+cEmjtj32CVu/I5LbfnXwMFYPQn6Ynsgw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266694 Bug ID: 266694 Summary: emulators/open-vm-tools rc script produces extraneous output, breaks puppet Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: garga@FreeBSD.org Reporter: ray@bellis.me.uk Flags: maintainer-feedback?(garga@FreeBSD.org) Assignee: garga@FreeBSD.org Created attachment 236929 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D236929&action= =3Dedit Fixed rc script The patch in commit eb65cf5cbe543a6372834bee33243344bc40f737 to "silence checkvm_cmd" is incorrect. This line: checkvm_cmd=3D"%%PREFIX%%/bin/vmware-checkvm > /dev/null 2>&1" does not cause stdout and stderr redirection, it simply passes the three ex= tra tokens to the vmware-checkvm command in argv. The correct solution is to define checkvm_cmd as a function: checkvm_cmd() { %%PREFIX%%/bin/vmware-checkvm > /dev/null 2>&1 } This error causes our puppet manifests to break because the extraneous outp= ut from `service vmware-guestd rcvar` causes puppet's FreeBSD "service" resour= ce provider to barf. I've attached a fixed version of vmware-guestd.in. In theory vmware-kmod.= in has the same issue but it hasn't bitten us the way this one did. --=20 You are receiving this mail because: You are the assignee for the bug.=