[Bug 266558] graphics/cairo DOCS option - Coordinating GNOME_HTML_DIR for Makefile and DOCSDIR for pkg-plist

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 23 Sep 2022 03:04:57 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266558

            Bug ID: 266558
           Summary: graphics/cairo DOCS option - Coordinating
                    GNOME_HTML_DIR for Makefile and DOCSDIR for pkg-plist
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: desktop@FreeBSD.org
          Reporter: lab+bsd@thinkum.space
             Flags: maintainer-feedback?(desktop@FreeBSD.org)
          Assignee: desktop@FreeBSD.org

Created attachment 236755
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=236755&action=edit
GNOME_HTML_DIR update for graphics/cairo

After beginning a ports upgrade this week, I noticed that the docs option has
been updated for graphics/cairo. Candidly, it seems that I'll have to catch up
with my ports email, for any info/follow through about the docs patches.

In review of my earlier patch, I guess this is a sort of patch update? 

Presently, I wasn't able to install the updated graphics/cairo port with the
updated docs option enabled. 

To my best estimate: With DOCSDIR set to ${PREFIX}/share/gtk-doc/html and that
being used in a similar way to GNOME_HTML_DIR from /usr/ports/Mk/Uses/gnome.mk
then the docs are then installed under ${PREFIX}/share/gtk-doc/html/cairo. The
pkg-plist is set to locate the docs directly in ${DOCSDIR} however.

At the time when I'd sent the earlier patch, I believe I wasn't then aware of
how GNOME_HTML_DIR is used in gnome.mk. /usr/ports/Mk/Uses/gnome.mk will pass
GNOME_HTML_DIR as the --with-html-dir to configure.

With the attached diff, graphics/cairo would use a DOCSDIR as
${GNOME_HTML_DIR}/${PORTNAME} and a GNOME_HTML_DIR as
${PREFIX}/share/gtk-doc/html. The gtk-doc files can then be located without
update to the pkg-plist


Thx for noticing the patch!

[1]
https://gitlab.com/FreeBSD/freebsd-ports/-/blob/main/graphics/cairo/Makefile

-- 
You are receiving this mail because:
You are the assignee for the bug.