[Bug 266405] devel/aws-c-common: Various Improvements

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266405

            Bug ID: 266405
           Summary: devel/aws-c-common: Various Improvements
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: eduardo@FreeBSD.org

Created attachment 236545
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=236545&action=edit
various improvements v0

This is a sample of next updates on aws* and other cmake ports.

Commit msg:
---
 - Define LICENSE_FILE
 - Add ports framework for unit testing
 - Use CMake helpers provided by framework
 - Remove unneeded CFLAGS+=-D__BSD_VISIBLE=1 since:

   ${WRKSRC}/source/posix/system_info.c:
   ---
   #if defined(__FreeBSD__) || defined(__NetBSD__)
   #    define __BSD_VISIBLE 1
   #endif
   ---
 - bumping PORTREVISION
---

doubts:

 - not sure about bumping PORTREVISION since build is untouched but
LICENSE_FILE
   was added and __BSD_VISIBLE removed
 - not really really sure about __BSD_VISIBLE but no build problems
 - add cmake:testing works fine

Any hints or fixes?

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.