From nobody Wed Oct 12 23:41:03 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mnq0b5Zdxz4fMPg for ; Wed, 12 Oct 2022 23:41:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mnq0b3zvcz4785 for ; Wed, 12 Oct 2022 23:41:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Mnq0b33mRzDg0 for ; Wed, 12 Oct 2022 23:41:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29CNf33H040789 for ; Wed, 12 Oct 2022 23:41:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29CNf3Aa040788 for ports-bugs@FreeBSD.org; Wed, 12 Oct 2022 23:41:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 265835] [NEW PORT] security/py-ssh-import-id: Authorize SSH public keys from trusted online identities Date: Wed, 12 Oct 2022 23:41:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: short_desc keywords flagtypes.name bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665618063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=60UC8hrLZuA93IA+qIgpsZ80fT3jCB3TeKFYpwsIPts=; b=A4pZhnsCVZLtCx73B7HFj/jWSBTlZH0NSzOLiixQrG6k+g+CITfjeVtvfqkyqHVmhhK09m Q1K0M6G/nNct5qtgFAeGaLLt1Z/DZXYMbfVU8oAOYRt+g5zgeu29KqsaEQ33FecROOxU3L TblYc8hx7oNP1dGLA/8hsyViAZqloIB/ovnk3q5iR8HZSTWF94n0k9PmvUsd6Hmx8zRDZT 1SWGmwzDz8zptmiznln04veCOPSGJ8CIcOJfxMYicGEtZb92C/6qjq3NE8QGZUO6+MjyNx 2lktR95bxEnnTYCZVLEuMwIRqPzLijpa6fNCHLBWoTp6cP8XzytngoW3Vby/1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665618063; a=rsa-sha256; cv=none; b=ulsOcvZ2FnAtIWBq9YIH5czQGSt/jDc0fX9xy15G1fCqvsuJAAvcRIgux+YKAANwthNRAH E/Mx0q/v1mDU1B3TH3pTUnpTY2S3B2p4JFcJqF2LfiA/dB0LIs5fIXUpUvydR29NRLMN8g uR9UvonDwMOnbIlnsW5TXsR9rLYIarqKwIyAMLG7VWFKGJJnSLEHxjx+86ZfDZNoY5tgbP vIPlxlNHjHlLI2hmAvLe/kdS+/h7m7EPNR4+m9I5P4t0hcfWgWf8XHvNz/KckJ/+OAquoy vCHSSBFy21Avi53fdfXaf/U9dX2PFRPG6l5jKy6+gK9hkrft/5u5GYBLa4aPyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265835 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|security/py-ssh-import-id: |[NEW PORT] |New port: Authorize SSH |security/py-ssh-import-id: |public keys from trusted |Authorize SSH public keys |online identities |from trusted online | |identities Keywords| |feature, needs-patch, | |needs-qa Flags| |maintainer-feedback?(p.mous | |avizadeh@protonmail.com) Status|New |Open --- Comment #1 from Kubilay Kocak --- Thank you for creating a FreeBSD Port Sayed Review items: * Add LICENSE_FILE if one is shipped with the distfile. If one isn't provi= ded, ask upstream to add one, and just add a `#LICENSE_FILE=3DNot shipped in PyPI sdist` in the comment for future reviewers/reminder to yourself and others. * USES=3Dpython: should be used declaratively, not imperativ= ely, to declare what version of Python a package supports (not which one to 'use= '). This is usually declared as a python_requires version spec in setup.py or similar. If not there, one can usually find a supported versions declaratio= n in documentation, or use the versions upstream tests against in CI. Closest I could find is a reference [1] saying versions > 2.6, which may or may not be the case actually. In these circumstances, the best method is to include TEST_DEPENDS and a (do-)test: target in the prot to run the package test suite, and verify the tests pass for the Python versions allowed by USES=3Dpython:. Ultimately this should be explicitly declared upstream, so ask upstream to declare that (in python setup and CI files to match). * Python packages that ship files in shared, non-versioned locations (like /usr/local/bin) should be made USE_PYTHON=3Dconcurrent safe. This makes it possible for multiple versions of the package install'able concurrently, without filenames conflicting. In most cases this takes the form on 'script= s=3D' and/or 'console_scripts' in setup.py, as this project does [2] * The package delcares a run time (install_requires) dependency on the 'distro' package [3], but this dependency is not declared in the port * You'll want to confirm the port passed QA (with portlint and poudriere at least). See the following for instructions: https://docs.freebsd.org/en/books/porters-handbook/testing/ If you need help getting this setup, we have #freebsd-ports on Libera Chat = IRC, or the #ports channel on our FreeBSD Discord where you can get support :) [1] https://git.launchpad.net/ssh-import-id/tree/README.md [2] https://git.launchpad.net/ssh-import-id/tree/setup.py#n53 [2] https://git.launchpad.net/ssh-import-id/tree/setup.py#n56 [3] https://git.launchpad.net/ssh-import-id/tree/setup.py#n54: install_requires=3D["distro"] --=20 You are receiving this mail because: You are the assignee for the bug.=