From nobody Sun Nov 27 18:25:22 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NKxq72zpVz4jRYf for ; Sun, 27 Nov 2022 18:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NKxq70gg3z4CQY for ; Sun, 27 Nov 2022 18:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669573523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6S0zcmIeci5tzf+0xzwGRkrb1QHpe5vrdBFaLm8EmLU=; b=mip3c3V9Ovg14PtSEq8PnJFpL+hDKeLE0NOx3pbVq1yczRvU9id8cjHsPuDQdodNj+kIQj WxTrcLs6yxhuvXBHRJiYzLnd/AIzWOxUQR8/kpHTyxSuLJF+Uzf3/QnxKvaWL/7sbFg8g/ 23L8jAN2Xn03eV4clVsgjFD6t8qnnhBECSKePWdsElRUjn0UPg9H4vfVYqzA24FCOz4Hbn ZSM1HaSriXhWDbodkD2nNjXtMmBYT7oC1a9pT/qsiCnqMrP428XQjNV0Kmhc6EdEXmOiRV Bpz5BZeNQYztwENB2mGHzz1JMjzw5ikkxyMX2DOVk1uVQkqVn6//YeP9JPqKtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669573523; a=rsa-sha256; cv=none; b=gMeRIeNPCMfXjatpZjKVMibGEae1vAVTNai+6tSJc2pAFKFhZJfAOsdcsvtmZ2Vo0uRSKP sSmoJE71bqd0lL7lVPSBDn343km+Yw0Fxs0O9NEdv61wCYmldGZr2B6i9OfFMGkYwxtGLl lgoNtOmRQqDzpBvLy9e0bmRJ8CUcDqdetkrpo9eGLYroZU/sFkNAJNXSu32499eoovv/m/ 6DcqhH2rDGb+i/TCN8uKoDZe2UwU8zqoHwjd1c/ANIHQ4YK1NikJnyCvtuTI1lM3/xcPe3 1k2Z5q0ExNoMwTnRqcAZejy2akCJhJMzvQfSvBJ8nMgdZDBuKNstVw7VvHpZLw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NKxq66bSpz17MS for ; Sun, 27 Nov 2022 18:25:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2ARIPMIp027000 for ; Sun, 27 Nov 2022 18:25:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2ARIPM7Y026999 for ports-bugs@FreeBSD.org; Sun, 27 Nov 2022 18:25:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 268018] textproc/py-sphinx: Updating to 5.3.0, ensuring themes are installed, using flit and pyproject-build Date: Sun, 27 Nov 2022 18:25:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lab+bsd@thinkum.space X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268018 Bug ID: 268018 Summary: textproc/py-sphinx: Updating to 5.3.0, ensuring themes are installed, using flit and pyproject-build Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: python@FreeBSD.org Reporter: lab+bsd@thinkum.space Flags: maintainer-feedback?(python@FreeBSD.org) Assignee: python@FreeBSD.org Created attachment 238375 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D238375&action= =3Dedit py-sphinx update to 5.3.0 using the new py build system textproc/py-sphinx is presently available in a version 5.3.0.=20 An update for py-sphinx may be of interest when updating some ports that use sphinx, e.g devel/py-nbclassic (if updating to 0.4.8) and devel/py-pip (if updating to 22.3.1) The attached diff introduces one approach to addressing the following conce= rns, such that might be encountered in any approach updating to 5.3.0 in py-sphi= nx; - Sphinx 5.3.0 uses PEP 517 conventions for the build. - This newer build system pyrpoject.toml, rather than a setup.py - via pyproject.toml, the upstream build then uses flit when preparing the sources for distribution. (Contextually, this mayu be for distributions with sdist and/or wheel archives, such that may then be published to intermediate repositories such as PyPI) - Using upstream conventions, the version in this updated build would be derived from Git changelog information. This changelog information is not available in the tar bundle downloaded from cheeseshop In the approached presented with this patch, pyproject-build and flit are u= sed to prepare the sources before building with distutils.=20 The approach of using pyproject-build to prepare the sources was referenced partly on some tooling in the Debian dh-python[1] project.=20 The distutils part of the build is referenced on the existing known-good approaches used in FreeBSD ports. To work around the concern about the dynamic versioning with the upstream pyproject.toml, a new patch is introduced, along with a post-patch call to inject a version string to pyproject.toml.=20 This version string is then available for distutils, without further modification on the upstream sources - e.g if there was a setup.cfg ensuring setuptools_scm would be used directly. There isn't in this project, but it seems it was used anyway. In this approach - mainly, in using pyproject-build and flit to prepare the sources before building with distutils - the package will be installed with= all source files, as filtered through flit, in addition to pyc files. This woul= d be for a given set of extensions and other configuration selected onto pyproject.toml for the respective upstream build components (here, using fl= it, with no extensions in this project's pyproject.toml).=20 Maybe other projects with a pyproject.toml and no setup.py could use a simi= lar approach, however possibly further refined. For this port, this approach has the effect that the sphinx themes and other non-py sphinx resources will be installed along with the pkg.=20 Thus, the basic sphinx theme and other sphinx themes will then be available with the updated port. The 'basic' theme itself may be required for the docs part of some other py-port builds - at least, after an update in each. This may include any po= rts using the textproc/py-sphinx-basic-ng them and thus transitively, textproc/py-sphinx_rtd_theme [1] https://salsa.debian.org/python-team/tools/dh-python/-/blob/master/dhpython= /build/plugin_pyproject.py#L105 --=20 You are receiving this mail because: You are the assignee for the bug.=