From nobody Fri May 27 04:01:55 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A4BDF1B51C82 for ; Fri, 27 May 2022 04:01:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L8WMl1jwRz3D77 for ; Fri, 27 May 2022 04:01:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1C3E71B3D0 for ; Fri, 27 May 2022 04:01:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24R41tNw014008 for ; Fri, 27 May 2022 04:01:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24R41tnj014007 for ports-bugs@FreeBSD.org; Fri, 27 May 2022 04:01:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 264271] comms/nanovna-saver: incorrect /dev/cua* to umodem number mapping Date: Fri, 27 May 2022 04:01:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jeffpc@josefsipek.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: hamradio@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653624115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q5RrEbiBeyRB9BZkpk18JXVYFaY21VMYmhePbBW0pF4=; b=mdDnylk3m6uqtzb9ksjzokGwW/ulbQ4VUdR2oKgH2TC/WlT4P7rOe4bURMkUFKkxJnjiQP Anz103OigLK65DNluf7WEjshkatzkViiIzMxgkasffLTbJ3Kn2ckr2yOu1NXqC7dGTSpux 5RbFOqy/nSVBJavS0TgC85eMU8KcV64nwdQvHUgsvbIo/aQNb9D/yOXTdHmbI7v/Qs/49X X14f5DZ3pBWElFMjpxGCHWbrSfnvDYniKL4+MBFYw19rH1AEM8WjxVXzU4B6PGslmVfYny zSEJB//emkl79T9D2Q8KqvLrSKoJbnuNgEs2SSNxBwnZ47kNksEP9Fv0LPz9ZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653624115; a=rsa-sha256; cv=none; b=EiwkSJdfqCi/cDjrKVRrefSqHbtB4WByARYsfnUVmzj6zZaYjtDFHzEVfajYNIis41WF+r oqCtGm6Z8gUpiRfsXBkD04zDBxT9DWAbw3wnZ+gI/sCOTVRHaRwkHTLKSYXmVZX0SEJALk wJth8gB4mnrO92rRKIEUZm4Jd/TgdNGMv1EacI6CAb82koRXVQ4Ddn05YAIH2ZtpTBcU5G baUQeDAcLvmWFvvlPerRX/19DTbPvtkdOTKQ5zN+3MliYJ1WCIazYZFdJVEKwClD04z5gP ig2RQaWggko6df4lM07OnzlsfUWHexEwE0fj9daxnRC4tJ5m1BrOSYLs21bFzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264271 Bug ID: 264271 Summary: comms/nanovna-saver: incorrect /dev/cua* to umodem number mapping Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: hamradio@FreeBSD.org Reporter: jeffpc@josefsipek.net Flags: maintainer-feedback?(hamradio@FreeBSD.org) Assignee: hamradio@FreeBSD.org While trying to validate an upstream fix to a device enumeration issue [1],= I realized that the ports package has a tweak to get the USB vendor & product= IDs from sysctl [2]. Unfortunately, this code is incorrect since it assumes th= at /dev/cua*N corresponds to dev.umodem.N. For example, on my system I see: $ sysctl -a|grep umodem hw.usb.umodem.debug: 0 dev.umodem.0.ttyports: 1 dev.umodem.0.ttyname: U1 dev.umodem.0.%parent: uhub5 dev.umodem.0.%pnpinfo: vendor=3D0x0483 product=3D0x5740 devclass=3D0x02 devsubclass=3D0x00 devproto=3D0x00 sernum=3D"510" release=3D0x0200 mode=3Dh= ost intclass=3D0x02 intsubclass=3D0x02 intprotocol=3D0x01 ttyname=3DU1 ttyports= =3D1 dev.umodem.0.%location: bus=3D2 hubaddr=3D2 port=3D8 devaddr=3D4 interface= =3D0 ugen=3Dugen2.4 dev.umodem.0.%driver: umodem dev.umodem.0.%desc: STMicroelectronics ChibiOS/RT Virtual COM Port, class 2= /0, rev 1.10/2.00, addr 4 dev.umodem.%parent:=20 The %pnpinfo and ttyname nodes state that dev.umodem.0 corresponds to /dev/cuaU1. As a result, NanoVNA-Saver fails to start with the following backtrace as it finds cuaU1 and then proceeds to attempt to get dev.umodem.1.%pnpinfo sysctl nodes: Traceback (most recent call last): File "/usr/local/bin/NanoVNASaver", line 33, in sys.exit(load_entry_point('NanoVNASaver=3D=3D0.3.10', 'console_scripts', 'NanoVNASaver')()) File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/__main__.py", l= ine 85, in main window =3D NanoVNASaver() File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/NanoVNASaver.py= ", line 92, in __init__ self.serial_control =3D SerialControl(self) File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/Controls/SerialControl= .py", line 37, in __init__ self.rescanSerialPort() File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/Controls/SerialControl= .py", line 67, in rescanSerialPort for iface in get_interfaces(): File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/Hardware/Hardware.py", line 86, in get_interfaces vid_pid =3D usb_vid_pid(d.device) File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/Hardware/Sysctl.py", l= ine 20, in usb_vid_pid result =3D (posix_sysctlbyname(b'dev.umodem.'+bytes(digit,'ascii')+b'.%pnpinfo')).deco= de('ascii') File "/usr/local/lib/python3.8/site-packages/NanoVNASaver/Hardware/Sysctl.py", l= ine 14, in posix_sysctlbyname raise Exception('sysctlbyname returned with error %s' % result) Exception: sysctlbyname returned with error -1 [1] https://github.com/NanoVNA-Saver/nanovna-saver/issues/502 [2] https://cgit.freebsd.org/ports/tree/comms/nanovna-saver/files --=20 You are receiving this mail because: You are the assignee for the bug.=