From nobody Mon Jun 06 10:19:14 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7F3371BF7EF7 for ; Mon, 6 Jun 2022 10:19:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LGqGX0LRdz4lnC for ; Mon, 6 Jun 2022 10:19:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9B9C123EEB for ; Mon, 6 Jun 2022 10:19:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 256AJFGZ060545 for ; Mon, 6 Jun 2022 10:19:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 256AJFPA060544 for ports-bugs@FreeBSD.org; Mon, 6 Jun 2022 10:19:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 264454] Do not build TEST_DEPENDS in case NO_TEST is set and do not run tests Date: Mon, 06 Jun 2022 10:19:14 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: se@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654510756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S0UZ2RGaJsfYTDdmSlbXlRVSA3rHqcHlv7hcBIhzaPc=; b=s95Z5SWqDmgM332+YqNrfjIeamuQGP5CpMT68iM4dIo0bGvikayDbrn6CJhau/M8x8PErM UKSGzfwK1bGUbZA33+lYaaxBRodcMaA9sJ8W8rkcINQXsNKKiAgyFoVccP9Ryde17c4uss RTsGUQhITJkoJw/ryO5EmjBlMIXkNUXu8/iAJyfkK8BgjnIOoEyKkItuhEGj4sL2gq/uaE tJYF5Gkj8VY0w7BcVVeGDSgbZAE7tPLC0lsKilzMSgCkDe9YKNX+iGZP0ycu2rINcUQ/Wy 9t3KYfQ9Z5rxFMpSsdPBbiB2NDUb3D7XAZI/BgQ4pJr4kmU+gIP2YUmTnBg9tQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654510756; a=rsa-sha256; cv=none; b=wB2ca72O/Xa3D+Fw4L0DOn5K0MkY1DlluUem96IsAM1XJWDwP6A3dUYk7cazEpoRW/mXui LfhZAsWd+cnEjfrPZGiuQStzm19pfAhxgaJKsh1kG4cCVVU6henebTeSz7X9a2qVeMFalP ePex/WGts9zzH/FhAE24G8F3bX+exbAnCIKdNNZHjZmr7IB4bJ6OXwnYSFfoTgnRZ5mYQV cpbu8AuHJ7w+Tv+VweZEV5I1Wvg0NyKK+HJxnX07i0aAz6pSs5vDcrhzYdi/UT/kgq8csk AYtw8Sctvp2DLuGAwkoVIFh9Xuaxlq3a2wHhurhaOOQnrvuF1hLDEw/sHdPWTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264454 --- Comment #7 from Stefan E=C3=9Fer --- (In reply to Tomoaki AOKI from comment #5) > make fetch-recursive currently forces downloading of TEST_DEPENDS. > This can consume excessive disk space. But why are you using these *-recursive targets at all? They are useful if you have off-line (air-gapped) systems and you want to f= etch files or provide packages for use on them. In that case you want to have all possibly relevant distribution files and packages included, just in case you want to "make test" on this system that= has no access to the Internet. I really do not understand why you are using these commands to perform port upgrades or other package management tasks. We have tools that optimize the upgrades, e.g. portmaster or portupgrade. T= hese do exactly what is required, and in an optimized way (e.g. fetch just the distribution files that will be required in the background, perform only th= ose builds that are required, ...). Portmaster has no dependencies (it is just a shell script), exists for some= 20 years and has continuously been adapted to comply with changes in the ports/package system. It lets you build ports and packages in just the same= way as 20 years ago, despite major changes in the ports system (e.g. the introduction of the PKGDB and of flavors). Try "portmaster -bgw -a" to update all down-level ports (and create packages and package backups of the previous version, just in case). (The -bgw param= eter can of course be set as default options in the ~/.portmasterrc file.) Try "portmaster -F -a" to just fetch required distfiles for all ports needi= ng updates in parallel. Using the *-recursive targets in the way you seem top do it is a significant waste of resources, and the port management tools mentioned above implement= the required logic to allow for efficient updates/upgrades. There is so much missing in bsd.port.mk if you want to make it efficiently support your use case that adding NO_TEST will just increase its complexity, but without solving the issues you are having due to inappropriate use of t= his functionality. There is no functionality to selectively build just the modi= fied ports this way, for example. There are other port and package management tools, I'm mentioning portmaster just as an example. You may prefer portupgrade, for example. --=20 You are receiving this mail because: You are on the CC list for the bug.=