[Bug 264454] Do not build TEST_DEPENDS in case NO_TEST is set and do not run tests

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 04 Jun 2022 21:36:48 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264454

--- Comment #3 from Stefan Eßer <se@FreeBSD.org> ---
(In reply to Bjoern A. Zeeb from comment #2)

> Have you looked at the diff?

Yes, and in fact I had mentioned that not including TEST_DEPENDS in
_UNIFIED_DEPENDS reduces the output of "make all-depends-list" by not including
TEST_DEPENDS.

But I do not see why this is relevant, since no port update operation should
depend on the output of that command.

Taking just one random port that has a TEST_DEPENDS entry not otherwise
depended on as an example:

$ cd /usr/ports/devel/fsmtrie

$ make -V TEST_DEPENDS
checkmk:devel/check

$ make all-depends-list | grep devel/check

$ make -C fsmtrie test-depends-list | grep devel/check
/usr/git/ports/devel/check

But I see that there is an issue with "make package-recursive" not respecting
the port options selected!

I have deselected DOCS and DOXYGEN, but "make package-recursive" still builds
and packages devel/doxygen.

This seems to be wrong (and has nothing to do with the TEST_DEPENDS
definition).

IMHO, "make package-recursive" should only create packages of the files
required as run dependencies when the fsmtrie package is installed (from a
package file).

But again: this has nothing to do with the suggested NO_TEST change.

It seems that nobody uses "make package-recursive" anymore, since port
management tools are the much better way to install ports and build packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.