From nobody Fri Jan 07 19:32:39 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 645F3193C0BE for ; Fri, 7 Jan 2022 19:32:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JVtfH719wz4sFW for ; Fri, 7 Jan 2022 19:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D259211238 for ; Fri, 7 Jan 2022 19:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 207JWd9I060568 for ; Fri, 7 Jan 2022 19:32:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 207JWdDW060567 for ports-bugs@FreeBSD.org; Fri, 7 Jan 2022 19:32:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261012] net-p2p/deluge-cli: optional dependency py38-setproctitle makes service script status break [PATCH] Date: Fri, 07 Jan 2022 19:32:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jocke@gipset.se X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rm@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641583960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VY0JpHBpdk1Meib9cTj7TsdT4WTZjlssyWHDYUMx0D4=; b=n55lbAGUlFSGXFbc6Qyv8mbEnKK4THUpsWh7ri8MRlsGxvLa1RguZLcg7HSTMqZXBqBUSb MaH9tdyWVtw81xPHAHuPes7w+Q2Yd7RICD5C5wn9LF8VsW+aRmz6gn23R0CYRWQp39Gjqc +RUAGivbV0nbjY8eNDqSsqRGbkiMZN8ZOahy5nNJXboIHMPMLhI/SqWH7aAv+WQusXiTPQ Jcse/zDh6cgvMTp/NH/756LqipEGmSh+PsqP0B4WB457dbt/HQg4dBYVydgKdvlvttAHka Tdyt7o+3bAon9nHH004RCq+S25KjWJQSNkf5+Hd161dOqaoSXRXmnneFfuF5Qw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641583960; a=rsa-sha256; cv=none; b=pxUifGBf8TNfFCqXmg4Jtzs08m6ySdGgMyY3vhljsLT+N780ClhRQWdkwgngFqOGcaWgvP bBCpkZNZ6JYkDFWzA8elBXd1NOHXEhZiQ5mEN3RuSloSvi6EWUOwLWshMZ82T0ja00qUbo 9lEPTkliKUv5XiCSGlwt8O91Dq75AEPQ14h6gQbKQaTSll6CTE6x1A9+C7k7tIUzEyy3es lhFNOXxIZHwPPkehuIyMsD2tDD1lJSJTQ0AO0Y5g0awaP0fixAGg/wk6bH+ZP5OwG4uekB ihHYR2mXlR3k+lCiqC1brXMoXJ/v5bRn6JYqgP0JC7WMY3UIJ7dhJ4xLts62oQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261012 Bug ID: 261012 Summary: net-p2p/deluge-cli: optional dependency py38-setproctitle makes service script status break [PATCH] Product: Ports & Packages Version: Latest Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: rm@FreeBSD.org Reporter: jocke@gipset.se Flags: maintainer-feedback?(rm@FreeBSD.org) Assignee: rm@FreeBSD.org Created attachment 230794 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D230794&action= =3Dedit removes dep on setproctitle and use pidfile in deluge-web service script This is my first bug report in freebsd, please be gentle :) I noticed deluge-web could not be restarted through its service script so I went looking into why. It turns out it doesn't set a pidfile. Fixing that, I immediately had another problem, that the process in the pid file could not= be matched by rc.subr[0] so it could not be restarted even with pidfile. It seems what while setproctitle makes for nice ps/top/htop output, it conf= uses rc.subr such that e.g. `service deluge-web status` cannot find the process = and stop/restart will not work (since the old process is still alive the new one cannot bind to the same port and fails with warnings in logs). Motivation for adding it to deluge in the first place [1]: > Set process name to match application using setproctitle > Using the setproctitle module the process name displayed in top > and other places will correctly reflect the binary name. This is an > optional dependency I believe, since the dependency is optional and falls back to noop implementations, that having functioning service scripts is more important = than nicer output in `ps`. A patch is included that is taken from my running sys= tem, but I have not actually tried these changes all the way from a manual port build (I am very new to freebsd so not exactly sure how to verify things anyway). [0]: https://cgit.freebsd.org/src/tree/libexec/rc/rc.subr#n316 [1]: https://github.com/deluge-torrent/deluge/commit/b396b11611be9c828090d1dafed= fb3cd3bf092f3 --=20 You are receiving this mail because: You are the assignee for the bug.=