[Bug 261637] www/rubygem-gollum: Remove unused dependencies

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261637

--- Comment #3 from Sir l33tname <sirl33tname@gmail.com> ---
Thanks for the feedback!

> What are the failure modes / effects, if any
Does not affect quarterly i guess since the changes are new.

For latest it means you can not use www/rubygem-gollum-lib as standalone.
(I don't think that is a use-case since the lib has a very strong coupling to
www/rubygem-gollum)

I broke that here:
-
https://cgit.freebsd.org/ports/commit/?id=644d2ef109a340cdf0d19561117db3d9e63b52f7
-
https://cgit.freebsd.org/ports/commit/?id=fef2fa5fd8a2a9e170be66133e9d535a9bc6fd4b

The default adapter changes with the update from
www/rubygem-gollum-grit_adapter10 to www/rubygem-gollum-rugged_adapter and i
added it to the wrong port.

> Does gollum-lib pass its test suite after patching dependency version spec? [1]
bundle exec rake test
/usr/local/bin/ruby27 -I"lib:lib:test:."
/usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3/vendor/ruby/2.7/gems/rake-13.0.6/lib/rake/rake_test_loader.rb 
root@freebsd:/usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3 # echo $?
0

I guess yeah also i already use this in my local setup and i guess it works.



> Could you confirm QA (portlint, poudriere) for these changes
www/rubygem-gollum # portlint
WARN: Makefile: extra item placed in the *_DEPENDS section, for example,
"USES".
0 fatal errors and 1 warning found.
/www/rubygem-gollum-lib # portlint 
looks fine

not sure about the first warning tried to fix it but when i move USES over the
RUN_DEPENDS section i get an other warning.

-- 
You are receiving this mail because:
You are the assignee for the bug.