From nobody Tue Aug 09 08:25:17 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M25jV1ZgXz4Y39D for ; Tue, 9 Aug 2022 08:25:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M25jV0KlCz3KTx for ; Tue, 9 Aug 2022 08:25:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4M25jT6LZHzQHH for ; Tue, 9 Aug 2022 08:25:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2798PH1N053644 for ; Tue, 9 Aug 2022 08:25:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2798PHJa053643 for ports-bugs@FreeBSD.org; Tue, 9 Aug 2022 08:25:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 265651] [NEW PORT] archivers/zpaqfranz: versioned/snapshot archive Date: Tue, 09 Aug 2022 08:25:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: zirias@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660033518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XcdKvB5f/hUBe5YSQyMSAjS5+8l95NvONYmg5uMuS/4=; b=e1C0iFa015/V/tBUmyqp2+7Z14cPqQCBzM1erfIOcuK+V3FUbUN/u/yZ1TmAnnVwF7UcsQ 6uVkM2vtKQTFwMtJ+JgBYDQTIPuUp9TjEF/ku9bTLq4cZRzwiHdd/4XwQRKKpqlz6B/YCU BkoDBbzYhwER0asj+lnaJ3c/LGlGBN9GYMY3PlGy3MWZ6KURXaJwLIXxdTdK07rUq9ZlC7 mnksIsVDRxMyvcFIMcrTQreH3e2rk2T5zilPpqm6oMfPxwPm0sf363mrTfp4Rzlpb+x/xa sLG/pw/flBLJxy3Q4TXiZKmhbdfTOGGVYeqsyvNvyGITyMFNE26hRJ7VxyDAhw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660033518; a=rsa-sha256; cv=none; b=pp5MxyV2uGOLpru/v1KWFmkRD4s2eEQpxJVBxIwVdrRi9pSNXPJsKdZFwDr3g8QBGLBpLi 1Cn9qXnKuJxNdVZZga8d5XBUTIu/8VRlmcPBzJuO95VHsutQ4fOwnVaJDdkEusdG2xLX63 IGXwqRcbUZE87X01JYG8nHezqSZvmTy80w4UcO2RgAM0qyQUiXkKedfmpQ47A/b2I1v+2w nAOGXXAuPhk/aj+AgVFhkBAXuyiNCdwjeGbcOwB/kJXwaW8y49GtE/kdLXOeZfzfdUCnmJ Dtg7k0/1+XNz2a7xnJvzUWLtipHRB2rH04XAEdAS88m0OIG6MPf6U9ENl7uedw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265651 Felix Palmen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zirias@freebsd.org --- Comment #1 from Felix Palmen --- Thanks for submitting a port! A few things require changes though: * Never set WRKSRC to WRKDIR. Instead, for an upstream distfile that doesn't create a subdir itself, set NO_WRKSUBDIR=3Dyes. * Never define do-build and do-install targes if upstream already provides a build system that can do them (which is the case here). * Always remove -march=3Dnative (you will need to patch the upstream Makefi= le for that). Packages must only contain generic binary code that works on every machine. * Similar for CPU features, you're checking for SSE2 on the building machin= e, but if the executing machine doesn't have it, it will fail. In general, you can't assume SSE2 on i386. * The upstream Makefile installs the same binary twice. Remove one of them.= If the second name is really strictly needed, replace it with a symlink. --- A simple fixed port could look like this: 1) remove everything in the port Makefile starting with WRKSRC=3D ... Inste= ad just use this: NO_WRKSUBDIR=3D yes CFLAGS+=3D -DNOJIT 2) add a local patch for upstream's Makefile, removing the -march=3Dnatice = and also the second install command. If necessary replace it with a symlink, e.= g. like this: ln -s zpaqfranz ${DESTDIR}${BINDIR}/dir --=20 You are receiving this mail because: You are the assignee for the bug.=