From nobody Fri Apr 29 12:15:16 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 382BE199B8D4 for ; Fri, 29 Apr 2022 12:15:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqWdw6Y3kz3LHn for ; Fri, 29 Apr 2022 12:15:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C158B4BAF for ; Fri, 29 Apr 2022 12:15:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23TCFGgo092248 for ; Fri, 29 Apr 2022 12:15:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23TCFGnI092247 for ports-bugs@FreeBSD.org; Fri, 29 Apr 2022 12:15:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263655] www/apache24: Remove automatic mpm fallback configuration Date: Fri, 29 Apr 2022 12:15:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ports@skyforge.at X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: apache@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651234516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YltEJiP1yMO21KZlpTWFr1xWQI3uweuPrEN0TAC6soA=; b=sZGi07UT2th3zGYPXHLL6zF9qiS4vg/oc7qDwqkBK2HQ5onKfeJR0/yDaOHkq68NXFrdqz zt4Vf0zG05rFoXHrbWQZnREjy5VyK1FwtoN1aeSp/c3H0MWBJ07Uy3dyVWQ1EdKtCKNU9g byxm7grF09IXgQHsIT0CooygcCY9BxjNQch3ftQs1oCRDBh+7X8Yb+u0yWfgrp4R1/MjlK nUXQ/N+tYf9o22A9X0iGoZMp75V2da83/Me2s9QAYTAUwd0ZRwZ+m1s8vdfrE1fehxjgyW E9yhDQ/mrjFHZ4pipZGd4df08wNzsqZehW8HHEfqAMTilohtDlMtHaYYv0QW0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651234516; a=rsa-sha256; cv=none; b=h9xDxFybOhsnAMtZOjXXwr2j6SCl124PuzsQ104QE0dSR60Y9XSJkiBX3gBdn6wOLR15nK /7EfrfqCBVXRQlXJQscmEgTZfZSI5MYhye7ajZnOB0fp8TeuFihIItK4F0cLlC7Gdaxf9a mqYRCZ/XKGUCCgEZv7/Pl41q5VkXBCGc+22nYnQeIwDqhk2blX3W/v4+hWgKPzo5/4UHj0 PmRIz5aukosAvBnxkxiaj9ZPbRxIjIErLSU+/5B8D1SMZvht/yxraEJQU0BiES88ZAKOBk MkoMBqKZP7bkXEkS2b1Zxj3sCMRasKyZIqIoYomReA+DUEGnfzY2QcKOWZDakA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263655 Bug ID: 263655 Summary: www/apache24: Remove automatic mpm fallback configuration Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: apache@FreeBSD.org Reporter: ports@skyforge.at Assignee: apache@FreeBSD.org Flags: maintainer-feedback?(apache@FreeBSD.org) Created attachment 233582 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D233582&action= =3Dedit www/apache24: Remove automatic mpm fallback configuration I'd like to propose a patch to remove the automatic fallback generation with mpm_prefork for www/apache24. Currently the apache24 package greps for a present MPM configuration in http.conf and creates a fallback configuration= in modules.d, which is included by default. I feel that this is problematic fo= r a variety of reasons: * It doesn't account for modular configurations: If the loading of an MPM module takes place in an included configuration (as would be the case for m= ost modularized configuration schemes, which are increadibly useful and common), the script generates a fallback configuration that may cause apache to eith= er load the wrong mpm module on restart, or cause it to fail starting alltoget= her. * It doesn't preserve changes to the file: Even if I keep the 000_mpm_prefork_fallback.conf configuration but uncomment the LoadModule statement, the configuration is simply overwritten on the next update/reinstallation of the package. * From a philosophical perspective, it feels like it's overstepping boundar= ies: We nowadays ship with a sample configuration that includes a well-intended default LoadModule statement for mpm_prefork. Whichever way the user decide= s to modify and diverge from that default configuration should be up to them. Creating non-sample configurations in places that would be sourced by defau= lt feels like it's taking things a step too far. Judging from the commit history, I think there was once a point for this ki= nd of behaviour to help with the migration from a static to a dynamic MPM back= end. But this was in 2015, so I think it's time to reevaluate this and, perhaps, move on. As a minor note: I think the configuration as it stands right now doesn't e= ven work properly anymore. At least my apache complains with the following: Syntax error on line 21 of /usr/local/etc/apache24/modules.d/000_mpm_prefork_fallback.conf: Cannot load libexec/apache24/mod_mpm_prefork.so into server: Cannot open "/usr/local/etc/apache24/libexec/apache24/mod_mpm_prefork.so" I've attached a patch that (I think?) removes this functionality in its entirety, as it really shouldn't be necessary anymore. All configurations h= ad ample time migrating and new installations come with a sane default anyway.= We could still preserve a warning on install, but I'm really not sure that's necessary anymore. In any case it would make my own personal use case a bit nicer to deal with= , as I have split the individual modules and their configurations in seperate fi= les in modules.d and currently need to pay attention to this everytime I update apache24, but I'd love to hear feedback and different opinions on this. :) Cheers, Sascha --=20 You are receiving this mail because: You are the assignee for the bug.=