From nobody Wed Apr 20 14:23:25 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 562A911DF1F1 for ; Wed, 20 Apr 2022 14:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kk2vx02rPz3Pg3 for ; Wed, 20 Apr 2022 14:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D7762157E6 for ; Wed, 20 Apr 2022 14:23:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23KENOis073064 for ; Wed, 20 Apr 2022 14:23:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23KENOYW073063 for ports-bugs@FreeBSD.org; Wed, 20 Apr 2022 14:23:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263159] [NEW PORT] games/solver Math quiz game Date: Wed, 20 Apr 2022 14:23:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@fuz.su X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650464605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P6/nJHfpF9kiOeyug/aiPXMTTk5okJIEqQFM0nrX3zM=; b=Gx3K7000PnaKMq5vG9n3rmBK7e6GCOzQenv46R6cpR4Jp22OjmYVqWdFcDmzUprIArvD6/ 625FgTouzDWhNMTrjr8hvlmV1xQcfzSbpZht+CoYz0qavnXxV2PBCz/VRM7QgJhPzNlvtr mTkIwCyjPSSkhLeFX3WrLIIdXS1Y6Sc9MJeLtyltGFphH7XaEm8eiUjpCaFdlXz5wyEshV XDjMcT2cKEOartLBuzZk5iFkpug8tnMMo+xsLyk/oSYaL9JjEGGuZGegtarf7ESPTebeYD eqaxfQBaua9FunkCqH8aw+Jbdbv5cpx1GLWW94b1LIuo+nBihhze0cq5wKPAbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650464605; a=rsa-sha256; cv=none; b=q5w+mrv307ocT3XBIs0jvGuh64G23KTtvmfl7rdD7GUwPyGPCDpogPf7b/JkDM1U9PS0lW 50BzFWEWWh57Mm+ZpCF007JcB1MSzBTiCHp4p6nvmHgZmGGsW0wh9MWUje0Iig4Tj0pNdm m6uu4aOMjhH44y1lg2R5PEx8Vb/wF/DgEMnQCCQgrrq5bL+ZYRSHp40mBqwBpzBNK8DFZ6 PQmEdJrlmx7j5alitvV+uc0CsuTjA9MWlC/SaEhysDaSSIPNafSyM1py+lzCiGXFR45uxz PK8FYLKzvwnaiL5UMgayYEub26624f3zUtxfNEd+zvyDQNUfEyJ3RBGAc5YJrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263159 --- Comment #2 from Robert Clausecker --- Hi, I suppose this is your project. Please consider fixing the git repository so it actually contains the source files, not an archive of them. Then tag a release and use USE_GITHUB to specify the master site. The current approach is not forbidden, but it's certainly very unconvention= al. As for LIB_DEPENDS, why do you use ?=3D ? Is there any particular reason? The SETUID logic is not going to work the way you envision it; setuid bits = must be specified in the plist. Instead use the pattern found in sysutils/cdrto= ols for this purpose. Why do you need Setuid functionality anyway? In any way, ports that setuid have to be treated with care as they are a potential security risk. If it is for score files, put the binary into the games group and setgid it= .=20 Install blank scores file using the @sample mechanism into the appropriate location (see games/nbsdgames for an example) such that they are writable to the games user. If it is for accessing the screen, I'm not sure if setuid is appropriate.=20 Check if one of the groups video, operator, or wheel do the trick, too. I forgot how exactly this works. Also consider porting your code to a library that works on X11 such as SDL2. Make sure to consistently use ${...} instead of $(...) in the port Makefile. Your distribution file seems to have no top level directory. Use NO_WRKSUB= DIR to have the ports system create one for you. Do not set WRKSRC in this case and change your do-build and do-install targets to take source files from WRKSRC, not WRKDIR.c --=20 You are receiving this mail because: You are the assignee for the bug.=