From nobody Thu Oct 21 18:10:40 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BC81B180923F for ; Thu, 21 Oct 2021 18:10:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HZwWh4pfpz3j88 for ; Thu, 21 Oct 2021 18:10:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8548820004 for ; Thu, 21 Oct 2021 18:10:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19LIAe5T042775 for ; Thu, 21 Oct 2021 18:10:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19LIAe8Z042774 for ports-bugs@FreeBSD.org; Thu, 21 Oct 2021 18:10:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 259332] net/pyrad: Update to 2.4 Date: Thu, 21 Oct 2021 18:10:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kai@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kai@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_status cc assigned_to bug_file_loc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259332 Kai Knoblich changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |kai@FreeBSD.org Assignee|ports-bugs@FreeBSD.org |kai@FreeBSD.org URL| |https://github.com/pyradius | |/pyrad/releases/tag/2.4 --- Comment #2 from Kai Knoblich --- Thank you for the patch, Gian-Simon! A few items for review: * The "setup.py" has "install_requires=3D['six', 'netaddr']", so "RUN_DEPEN= DS" needs to be added and set accordingly. (Just loading the Python module via "import pyrad" doesn't cause any errors without those dependencies). * Adding a "do-test" target will improve future QA and can catch issues with missing or incompatible dependencies. * The examples files that are installed via the EXAMPLES options are still present in the upstream repository but aren't added to the sdist package. Switching to USE_GITHUB for a while until upstream re-add the examples to t= he sdist should fix this. In that case LICENSE_FILE can be used as well, beca= use the license file isn't available in the sdist, yet. For the case, if the EXAMPLES option should stay (which I would prefer, IMH= O): * The install target for the EXAMPLES option can be modernized via "post-install-EXAMPLES-on". * Add "concurrent" to "USE_PYTHON" to make the package concurrent safe, as = it installs the example files to $PREFIX/share/examples/pyXX-pyrad" (=3D XX Py= thon flavor) instead $PREFIX/share/examples/pyrad" Would you like to update your patch and add the above items? If not, it's n= ot a problem either, in this case I'd add the items before committing the update. --=20 You are receiving this mail because: You are the assignee for the bug.=