From nobody Tue Oct 19 08:12:03 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EC6F917FFD64 for ; Tue, 19 Oct 2021 08:12:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HYRKt6Hxgz3P7b for ; Tue, 19 Oct 2021 08:12:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B83AD10B2E for ; Tue, 19 Oct 2021 08:12:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19J8C2cQ057461 for ; Tue, 19 Oct 2021 08:12:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19J8C2NJ057460 for ports-bugs@FreeBSD.org; Tue, 19 Oct 2021 08:12:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 259259] Mk/Uses/emacs.mk: Remove Emacs major version from EMACS_PKGNAMESUFFIX Date: Tue, 19 Oct 2021 08:12:03 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: yasu@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259259 --- Comment #1 from Yasuhiro Kimura --- Let me note one thing about the value of EMACS_PKGNAMESUFFIX. You may think that including 'emacs' in EMACS_PKGNAMESUFFIX is needless and simpler values such as following are better. ---------------------------------------------------------------------- Flavor EMACS_PKGNAMESUFFIX ---------------------------------------------------------------------- full "" (empty string) canna "-canna" nox "-nox" devel_full "-devel" devel_nox "-devel-nox" ---------------------------------------------------------------------- I also thought so at first but I noticed it may cause problem. As is often the case with actively developing software, there are some cases that both release and development version are in the ports tree. And under = such situation, the former is created as 'category/foo' and the latter is often created as 'category/foo-devel'. And the problem happens when there are su= ch ports and they depends on Emacs. Now let me select 'devel/magit' and 'devel/magit-devel' as example of such ones. If we adopt EMACS_PKGNAMESUFFIX above then packages name of each flav= or of these ports are as following. ---------------------------------------------------------------------- Flavor of port package name ---------------------------------------------------------------------- devel/magit@full magit-3.3.0 devel/magit@canna magit-canna-3.3.0 devel/magit@nox magit-nox-3.3.0 devel/magit@devel_full magit-devel-3.3.0 devel/magit@devel_nox magit-devel-nox-3.3.0 devel/magit-devel@full magit-devel-3.2.1.76 devel/magit-devel@canna magit-devel-canna-3.2.1.76 devel/magit-devel@nox magit-devel-nox-3.2.1.76 devel/magit-devel@devel_full magit-devel-devel-3.2.1.76 devel/magit-devel@devel_nox magit-devel-devel-nox-3.2.1.76 ---------------------------------------------------------------------- Then please keep your eyes to the package names of following 2 cases. * 'devel/magit@devel_full' and 'devel/magit-devel@full' * 'devel/magit@devel_nox' and 'devel/magit-devel@nox' In both case the difference is only version number. Though I haven't actual= ly found it yet, it is quite possible that it causes malfunction of some tools doing something with ports/packages. And there is worse case. When it is just after the release of new version, = it is possible that both release and development version is exactly same one. = And under such situation package name are exactly same including version number with these 2 cases. This definitely causes disaster. So we need to add something extra to EMACS_PKGNAMESUFFIX in order to prevent such problem. --=20 You are receiving this mail because: You are on the CC list for the bug.=