From nobody Mon Nov 22 17:34:19 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DF74018AB06C for ; Mon, 22 Nov 2021 17:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HyZBz5czSz4fCq for ; Mon, 22 Nov 2021 17:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A1AF0267F3 for ; Mon, 22 Nov 2021 17:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1AMHYJAV038405 for ; Mon, 22 Nov 2021 17:34:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1AMHYJod038404 for ports-bugs@FreeBSD.org; Mon, 22 Nov 2021 17:34:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 255670] Mk/Keywords/sample.ucl: Deleting any configuration files automatically is a bug Date: Mon, 22 Nov 2021 17:34:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dave@jetcafe.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255670 --- Comment #13 from dave@jetcafe.org --- (In reply to Baptiste Daroussin from comment #12) > When I remove a package I don't want any leftovers left behind by default= .=20=20 Ah! This implied policy speaks directly to my issue. :)=20 I think I understand the intent of this code, thank you for that. However, = the condition where the package sample file is the same as it's installed configuration file is (at least for the nginx package) created by the person who installed the package. In the case of nginx, for example, the "mime.types-dist" file might be copied to "mime.types". That is a local po= licy decision, right? Maybe the user has written some other tool that expects th= at file to be there.=20 Note well that even if the files are the same, the original nginx pkg insta= ll does not create a "mime.types" file by default: > pkg info -l nginx | grep mime.types /usr/local/etc/nginx/mime.types-dist > So to create "mime.types", the -dist version of the file might be manually copied by the pkg user, which I believe is a valid use case.=20 Are there packages that actually -do- copy dist files to target files? If s= o, those would be counter examples. > if we want to do what you want to do we should move this to post-deinstal= l, then pkg needs to be modified to allow this (which is doable, takes more= time and is probably desirable). I'm not very familiar with the distinction between pre-deinstall and post-deinstall, so I'm not immediately understanding why moving the same co= de to post-deinstall would somehow prevent the case where (using my example ab= ove) the mime.types file would not be removed on a pkg upgrade.=20=20 Are you talking about using my patch in post-deinstall instead of pre-deinstall? --=20 You are receiving this mail because: You are on the CC list for the bug.=