From nobody Sat Nov 20 18:48:42 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E8FE0182BEA1 for ; Sat, 20 Nov 2021 18:48:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HxMxk62mFz4nc5 for ; Sat, 20 Nov 2021 18:48:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id ABA0820E3F for ; Sat, 20 Nov 2021 18:48:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1AKImgAj083745 for ; Sat, 20 Nov 2021 18:48:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1AKImgHn083744 for ports-bugs@FreeBSD.org; Sat, 20 Nov 2021 18:48:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 259953] net/minidnla rescan support/fix Date: Sat, 20 Nov 2021 18:48:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gerrit@weinberg2.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259953 Bug ID: 259953 Summary: net/minidnla rescan support/fix Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: gerrit@weinberg2.de minidlna comes with a "rescan" command for rc.d. However, this reads rescan_cmd=3D"$command -R -u $minidlna_uid -f /usr/local/etc/minidlna.conf" This is in line with the manpage, but obviously wrong when comparing to the commandline help (minidlnad -h): -r forces a rescan -R forces a rebuild So "-R" forces a rebuild of the database while a rescan uses "-r". I verifi= ed that this is what is actually happening by checking the database file and t= he time each command takes (rescan is fast and just adds new stuff, rebuild ta= kes much longer and also removed outdated entries). Thus I propose to change the rc.d script to contain extra_commands=3D"rescan rebuild" rescan_cmd=3D"$command -r -u $minidlna_uid -f /usr/local/etc/minidlna.conf" rebuild_cmd=3D"$command -R -u $minidlna_uid -f /usr/local/etc/minidlna.conf" Furthermore, as this is not handled via signals on the running process, it might be useful to force a stop command before doing either rescan or rebui= ld. --=20 You are receiving this mail because: You are the assignee for the bug.=