From nobody Mon May 31 16:31:05 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D2BAFE719C1 for ; Mon, 31 May 2021 16:31:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fv14n4kf9z4Rht for ; Mon, 31 May 2021 16:31:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8312213A98 for ; Mon, 31 May 2021 16:31:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14VGV5VM049808 for ; Mon, 31 May 2021 16:31:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14VGV5gg049807 for ports-bugs@FreeBSD.org; Mon, 31 May 2021 16:31:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256301] bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH Date: Mon, 31 May 2021 16:31:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256301 Bug ID: 256301 Summary: bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: avg@FreeBSD.org CC: ports-bugs@FreeBSD.org There are several ways of handling recursive targets. I found at least Mk/Scripts/do-depends.sh Mk/Scripts/depends-list.sh _FLAVOR_RECURSIVE_SH It looks that the latter has a couple of problems comparing to others. First, it does not handle '@' in a port name. Second, it would set FLAVOR to the empty value even if a package is not "flavored". That can confuse some ports. A fast demonstration of the second problem: $ make -C /usr/ports/lang/gcc9 checksum-recursive ... =3D=3D=3D> native-binutils-2.33.1_4,1 depends on file: /usr/local/sbin/pk= g - found =3D=3D=3D> Fetching all distfiles required by native-binutils-2.33.1_4,1 fo= r building ... Note how the package name is native-binutils instead of binutils. A longer demonstration of the problem would be with the package-resursive target. That issue was reported and analyzed some time ago, unfortunately with no action: https://www.mail-archive.com/freebsd-ports@freebsd.org/msg84543.= html The proposed change brings _FLAVOR_RECURSIVE_SH closer to the other recursion methods and it should fix both of the problems: https://reviews.freebsd.org/D30579 --=20 You are receiving this mail because: You are on the CC list for the bug.=