[Bug 249144] pkgbase: /usr/tests/ subdirectories in non -dev/-dbg plist files

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 23 Dec 2024 22:04:14 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249144

--- Comment #3 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3a56015a2f5d630910177fa79a522bb95511ccf7

commit 3a56015a2f5d630910177fa79a522bb95511ccf7
Author:     Isaac Freund <ifreund@freebsdfoundation.org>
AuthorDate: 2024-12-23 21:54:29 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-12-23 22:03:30 +0000

    pkgbase: fix inclusion of tests in ssh, bsnmp, clibs-dev

    Currently, files that belong in the tests package are included in the
    ssh, bsnmp, and clibs-dev packages:

    ssh.plist
    24:@dir(root,wheel,0755,) /usr/tests/secure/libexec
    25:@(root,wheel,0444,) /usr/tests/secure/libexec/Kyuafile

    bsnmp.plist
    82:@dir(root,wheel,0755,) /usr/tests/lib/libbsnmp
    83:@(root,wheel,0444,) /usr/tests/lib/libbsnmp/Kyuafile
    84:@(root,wheel,0555,) /usr/tests/lib/libbsnmp/bsnmpd_test

    clibs-dev.plist
    2518:@dir(root,wheel,0755,) /usr/tests/lib/csu
    2519:@(root,wheel,0444,) /usr/tests/lib/csu/Kyuafile

    This is caused by the PACKAGE=foo assignment in foo/Makefile.inc which
    overrides the default PACKAGE?=tests in bsd.test.mk.

    To fix this, instead use PACKAGE?=foo in foo/Makefile.inc and set
    PACKAGE=tests in foo/tests/Makefile.

    PR:             249144
    Reviewed by:    bapt, emaste
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D47025

 lib/csu/Makefile.inc          | 2 +-
 lib/csu/tests/Makefile        | 2 ++
 lib/libbsnmp/Makefile.inc     | 2 +-
 lib/libbsnmp/tests/Makefile   | 2 ++
 secure/libexec/Makefile.inc   | 2 +-
 secure/libexec/tests/Makefile | 1 +
 6 files changed, 8 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.