From nobody Wed May 10 00:21:27 2023 X-Original-To: pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QGG0m0TWWz49lRp for ; Wed, 10 May 2023 00:21:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QGG0l2Slvz3pVZ for ; Wed, 10 May 2023 00:21:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683678087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pu8kQChDgOttxCuSKTsD7ShhEyRd1Guuv5uZMqjTWSA=; b=DumxwruFcyEhAbcG9BXn9VHQHtBJeeC5cAWk5KafJEF2Vnt1sG+jY7UTmIaE8ssQvn6jyG nOaa5MvJuyb96pCGGhXJmFfmz508GUUqQvz//eMwxIgi9XrTMnr7sG78Uqdl7mbHlO9Dix ZdsV/5Qco4KWDGf5XYw74fQKghZABVzR6ZpubgPEsjg9nvnOgGYH/HZwt07tBGI1bTZP/f nDRplFP8f1nLAdOXOtEY58E1exewUDn13Ksq6zE5SyKobwLScEaOZY2URf3f4VDXAR3b3y NRIoR1glzKU4709mBo2DFlxbvhk+UmNsV7Idgom+k4ERzHADCg9+1tNUl6PvTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683678087; a=rsa-sha256; cv=none; b=fhBV3gw+AEl1Afh2wWWwlsp1+kPdoC1NAttgKku6VB4nZKYjIfXCDsnTv2O8R/zxtbJpg+ GLpTI2Ur9rCYQLNGhzincXUKh0WROOQpodIVUm5pI6cIVS77cKWLjOJ+K/SpoMJ6pOzzVe anzVvN+dPWQDoxMU1UvsM/ZuRmgpdCuRz8LQfYmSSdpj4IKeuD62cmPYQtkT9Nn4oM1t71 sUNeFjQuCVWwimNT33cZzebvhNtCqs1MtOuOBOYFSvLIUD9rhbLrQcafIvvyuAd/+ky4rr mTwOKItcomq5vKba361MU4VkhsOMU47m9/AA437DUuox8xeXb/SJlxJ6lKwEjg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QGG0l1YJzzplj for ; Wed, 10 May 2023 00:21:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34A0LRQX073484 for ; Wed, 10 May 2023 00:21:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34A0LRe9073483 for pkgbase@FreeBSD.org; Wed, 10 May 2023 00:21:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pkgbase@FreeBSD.org Subject: [Bug 271178] loader.help.* files installed multiple times Date: Wed, 10 May 2023 00:21:27 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: loader, pkgbase X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: imp@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271178 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De32fecd0c2c3ee37c47ee100f169e7eb0= 282a873 commit e32fecd0c2c3ee37c47ee100f169e7eb0282a873 Author: Ed Maste AuthorDate: 2023-05-05 17:43:33 +0000 Commit: Ed Maste CommitDate: 2023-05-10 00:18:19 +0000 loader: install help files only once Every file should be installed exactly once by `make installworld`. This is especially important for pkgbase. Loader help files were being installed by each loader variant (e.g., the simp, lua, and 4th EFI loaders). Add a (slightly hacky) mechanism to skip installing help files for all but one variant. PR: 271178 Reviewed by: imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D40021 stand/efi/loader_4th/Makefile | 1 + stand/efi/loader_lua/Makefile | 1 + stand/i386/loader_4th/Makefile | 1 + stand/i386/loader_lua/Makefile | 1 + stand/loader.mk | 2 ++ stand/userboot/userboot_4th/Makefile | 1 + stand/userboot/userboot_lua/Makefile | 1 + 7 files changed, 8 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=