From nobody Sun Jul 14 13:40:48 2024 X-Original-To: pkg@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WMRL90wDpz5Qdm0 for ; Sun, 14 Jul 2024 13:40:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WMRL84kwYz40HY for ; Sun, 14 Jul 2024 13:40:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720964448; a=rsa-sha256; cv=none; b=uKo7bCZ24gfO4PEp4GnZpE6J7P6XEKBJrMmHl1dUZOADPYtivEbcOrUA9t2qOY1KLU/Bvd Ycr/HsM9VvEQZkRz+myiAH1C9tWMfEJy6bg6xOPADg86vAlYfKe7IcWeLI8QCrkTImeEsu i2Ugc30pVSbhn7XfHOJfkp6BtbN9J7XrUWvvMLpNheZ/mQ1hAvClV/Ii2IrugtyuxRM9g2 nB9DM/7PVib9aA6nfY78fKLeUUFhAqLjoL1Gpod/OKgiEySyBGO6wL+XwdeU7XWGT17zBd pUugnEOkKpaLcZ0pvmzj0NpICaU7W5QrDvNeNO27w4R85VZwIE3y7KErjRhRdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720964448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yMf8oy82dW1NQXCoTv9QrJo0Go208uzvePkHfFhgGPw=; b=E9/uQTGuDV7/x4whbAOCA0XOV7e4skqnRTBGeIz5P/ZfI5CISXp50NZBHDCEBCzSgmvhl6 n4R9Pbyj6jMBafUDlVXEksA4hHWmD24s98PqU+dYNtP7Kpi7abJvQtl5Yx3zLFZFbLjTEa gMIDdFS0G0VdKYljJieIH7LlR18gCUZdgx2XRCEdjBNLxdqm+JiRg92SCzMBUvVmlJZsDA J31kkmlOYBlUrpeYulgxJXvqzgXN+iu/WYAgdKB+/X9hLcTFyVmF9HZuNU83snb+vRG4hH GhqEx/HGHWgbrP+J0tPXtUFlaO+vl1/z+ro+95V/Q/9I6b+bHHXT5x2A2NYWDg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WMRL84HZ3z1B1f for ; Sun, 14 Jul 2024 13:40:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 46EDemCg083452 for ; Sun, 14 Jul 2024 13:40:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 46EDem23083417 for pkg@FreeBSD.org; Sun, 14 Jul 2024 13:40:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pkg@FreeBSD.org Subject: [Bug 280275] ports-mgmt/pkg: Wrong exit code in periodic script 490.status-pkg-changes Date: Sun, 14 Jul 2024 13:40:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: andrestoebe@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pkg@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_severity Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Binary package management and package tools discussion List-Archive: https://lists.freebsd.org/archives/freebsd-pkg List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkg@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280275 Andre Stoebe changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Affects Only Me |Affects Some People --- Comment #1 from Andre Stoebe --- Actually, I think this whole list_rc dance is not needed and the original c= ode is fine. The only change with my diff would be that the exit code of pkg and cmp is passed-through and the periodic script might return > 2. Here's a minimal diff for the original issue: --- /usr/local/etc/periodic/daily/490.status-pkg-changes 2024-05-23 03:05:49.000000000 +0200 +++ 490.status-pkg-changes 2024-07-14 15:38:50.344033000 +0200 @@ -20,7 +20,8 @@ rc=3D$? cmp -sz $bak/$bak_file $bak/${bak_file}2 - if [ $? -eq 1 ]; then + rc=3D$? + if [ $rc -eq 1 ]; then diff -U 0 $bak/${bak_file}2 $bak/${bak_file} | \ grep '^[-+][^-+]' | sort -k 1.2 fi --=20 You are receiving this mail because: You are the assignee for the bug.=