From nobody Fri Feb 16 09:40:46 2024 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tbn3z16kSz5BP5p for ; Fri, 16 Feb 2024 09:40:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tbn3y6frzz43RK for ; Fri, 16 Feb 2024 09:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708076446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e+uU3hgwmQgx9A2OzQnAIhaP/qch7G7OzjXWQ+Yr7+8=; b=aIWu3Cz46x6ar1mI3lgY6EgsFjUi9UDrQCZcjizo70hMwJAEe1bKAaNiHTjMW8QtUr7UGf xCBzxAxv9FhRhxVXFuo2iElG6iVJ4tNINcRcU3XsrI/EpgLG+zz1m8JLaXCBXq9XmjmF3B xZ1MZtg4dxu4+fMM8gtlEWbkxbepqCybMdcxSQyWnWgi7CHt9YNVxKT6WyGP3np2qLKwOw yHFCcoZy+2cYFMWsecVEw4DxKPR4PXBWg9Kwy6qefETDSZZ+UiIWZSUTAJm8l6iaZ3j4c8 /GNAn5Rd04ZF4tTkJ4QSqnvc5yVgWWpUV1WSiDN2t0ShE/9S7PGMmYXiZRI3ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708076446; a=rsa-sha256; cv=none; b=JRRFHloWqNXv4PuKP4qsM3n+Bc+ggQ70KqQgwY8S7PyVA7g+IQkpEI2IiPt9TUQ/VOL+Zt EtQPrdgOSnLN4SShxSRFfr4uHQxdb/jikrr0l8s+fR33TbbuSuQsQ6WVq7BIf9gfufr6aw YgSY+Jsr4nKkvQWdxOXAlH9BOMHYZ2jkg5ERYqsrcfWO3e/j6qWgU5/LhKoYQx/1OxVGKg rmKtqSBBdwV78q+T0GhghhPCER2h3jTW8BEzVk0rexrk1RsMl6iGlT6pp62RhpSdz6lcpL JOkONWfoUXf4PtvDtVjQTX9lKn1XsinAHKkXJ2A3wmTt1nYcDGJZL5U9xCbkVw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tbn3y5lvvzKH8 for ; Fri, 16 Feb 2024 09:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41G9ekn3046609 for ; Fri, 16 Feb 2024 09:40:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41G9ekel046607 for pf@FreeBSD.org; Fri, 16 Feb 2024 09:40:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 276856] pf no longer re-assembles fragments by default Date: Fri, 16 Feb 2024 09:40:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: michal.os@hotmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276856 --- Comment #5 from Michal Scigocki --- I looked some more into what happen to pf fragmentation between 13.2 and 14= .0. The updates from this review: https://reviews.freebsd.org/D38025 made some changes to scrub and some other pf features. In file pf_norm.c, the default path for a fragmented packet changed from PASS to DROP. The condition on li= ne 1090 in that file on 14.0-RELEASE (currently also the same line number on 14-STABLE) makes the decision to DROP. This has since been fixed on CURRENT (default behaviour will PASS a fragmen= ted packet again). The updates were part of the following reviews: - fix to source code + tests: https://reviews.freebsd.org/D42355 - fix to documentation: https://reviews.freebsd.org/D42270 I think what is left is just getting the exiting updates from reviews D42355 and D42270 into 14-STABLE. --=20 You are receiving this mail because: You are the assignee for the bug.=