From nobody Wed Nov 08 21:56:37 2023 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SQf794tgQz50S7H for ; Wed, 8 Nov 2023 21:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SQf793T3rz4cHx for ; Wed, 8 Nov 2023 21:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699480597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OJmoaHL6DwtUNS497nccKZfU8RsH7BzPlIvlmks4Lsk=; b=mMYWcetrQObIgFfMEQgcCQb45HX0p+YJGJHGhh4t2tcy5gHHQuW05vCgw7GttWJqu13AbW 5OrxrYOtHI0lwaNafsqAzSpKKn16wS2s/v6nX6Yq/lpy0MEkZ3ecTGPYYCb1KvRmDpq3G5 ypw3baXnbKVFeT1Sda8TWQq3EIQuIY5JtaW0cW6r08Dr3M+NaAtNJ+rRcmlcaTNOpOtvOG jIEikVOHgmMa6ybSYnD/Gb3n6TPf0HxchiUSTor70f4QYKg6uOUoKgojZHR3fq9hGDBKl5 wm6oRktFfUdBHNYIIpqgdxr43nC10JU3kJnJbs4hrI65gmUg7w8i46m8rtZBvw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699480597; a=rsa-sha256; cv=none; b=J3Kq2JROUVunMHPfHuqhhXdGyPIoNYKyIQetkI22aJUA283FJh1GAG3EY7wOkYFfd5XCI2 x9WsKbrTNEmKek3SgUQcPM8ZkK5BY6FApYuOHlxPQ40HTsgQfcVOuPTfEGGqiD0lfESt+i lbM8CCbjsPeBPp7sCwiw0IyVsA0V4cGEd/tufRRdNTT9uI3ZFsahbYPl8v+cBMGjnnhJc6 p/PyXdWleSvWBFFa+DzaQ83jgJWUtcJPr9ZBaw9XJaL7xqX/7m5ij/8B0dwSJokDSwMdEN fWf9PdwvA4zlgN70bCGtSe29rtNYj+Aup3oGWc3mygTrgHaUqUZw5JZHYysj1g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SQf792S8dzphM for ; Wed, 8 Nov 2023 21:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3A8Lubsn067002 for ; Wed, 8 Nov 2023 21:56:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3A8Lubdh067001 for pf@FreeBSD.org; Wed, 8 Nov 2023 21:56:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Date: Wed, 08 Nov 2023 21:56:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da6246a50b63450d0fe34e3429807bd5ab= a8cc2ac commit a6246a50b63450d0fe34e3429807bd5aba8cc2ac Author: Kristof Provost AuthorDate: 2023-11-08 14:06:15 +0000 Commit: Kristof Provost CommitDate: 2023-11-08 20:58:52 +0000 pf: fix double free if pf_ioctl_addrule() fails If pf_ioctl_addrule() returns an error it will have freed the rule itself. There's no need for the caller to free it again. PR: 274915 Reported by: Dave Cottlehuber MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") sys/netpfil/pf/pf_nl.c | 3 --- 1 file changed, 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=