Re: route-to, interfaces and pfsync

On 13 Jun 2022, at 19:49, Kajetan Staszkiewicz wrote:
> On 2022-06-13 14:33, Kristof Provost wrote:
>>> This brings us to OpenBSD. They have decided to drop the interface
>>> from route-to targets
>>> (https://github.com/openbsd/src/commit/5812a4ad62ca07807ac0bc59f22eb8813e6069bc
>>> <https://github.com/openbsd/src/commit/5812a4ad62ca07807ac0bc59f22eb8813e6069bc> ).
>>> How about we do the same? If porting this change from OpenBSD has a
>>> chance of getting aproved and merged, I'd be willing to work on it.
>>
>>
>> That’s a breaking syntax change, at there’s at least one major FreeBSD/pf user that relies heavily on route-to (i.e. pfSense). So something that’d break that is not going to be easy.
>>
>> However, (without having looked at the patch in great detail) we might be able to support both the old style |route-to (epair0a 1.2.3.4)| and a new |route-to (1.2.3.4)| or even |route-to (@1.2.3.4)| or something if that disambiguates better. If we can ensure the old style keeps working (with any limitations it currently has), which also supporting the new style that’d give everyone a chance to migrate. We could then remove the old style in say 15.0.
>
> How about I make the parser accept the syntax with the interface and without it and then ignore the interface, and the pf C code will be all done without the interface? Would that have a chance of being accepted into 14.0?
>
That’d be a pretty significant behaviour change, so I’m not a fan. It’s bound to trip people up.

Kristof