From nobody Sat Sep 18 08:10:19 2021
X-Original-To: freebsd-pf@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4BEBE17C589F
	for <freebsd-pf@mlmmj.nyi.freebsd.org>; Sat, 18 Sep 2021 08:10:39 +0000 (UTC)
	(envelope-from kp@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4HBNmb1k7yz4Z7Y;
	Sat, 18 Sep 2021 08:10:39 +0000 (UTC)
	(envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [5.9.86.228])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mx1.codepro.be", Issuer "R3" (verified OK))
	(Authenticated sender: kp)
	by smtp.freebsd.org (Postfix) with ESMTPSA id 02C5E25699;
	Sat, 18 Sep 2021 08:10:38 +0000 (UTC)
	(envelope-from kp@FreeBSD.org)
Received: by venus.codepro.be (Postfix, authenticated sender kp)
 id C2FEB28179;
	Sat, 18 Sep 2021 10:10:33 +0200 (CEST)
From: Kristof Provost <kp@FreeBSD.org>
To: =?utf-8?q?=C3=96zkan?= KIRIK <ozkan.kirik@gmail.com>
Cc: freebsd-pf@freebsd.org
Subject: Re: pf label $nr macro expand reproducable bug
Date: Sat, 18 Sep 2021 10:10:19 +0200
X-Mailer: MailMate (1.14r5818)
Message-ID: <90E32279-76C0-4D81-B209-BE85A181F874@FreeBSD.org>
In-Reply-To: <CAAcX-AFmFwyEK4uzK66LoBK2e6W0_-8ZkJju5jAfSYE7wmSjXA@mail.gmail.com>
References: <CAAcX-AFmFwyEK4uzK66LoBK2e6W0_-8ZkJju5jAfSYE7wmSjXA@mail.gmail.com>
List-Id: Technical discussion and general questions about packet filter (pf) <freebsd-pf.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-pf
List-Help: <mailto:pf+help@freebsd.org>
List-Post: <mailto:pf@freebsd.org>
List-Subscribe: <mailto:pf+subscribe@freebsd.org>
List-Unsubscribe: <mailto:pf+unsubscribe@freebsd.org>
Sender: owner-freebsd-pf@freebsd.org
X-BeenThere: freebsd-pf@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam: Yes
X-ThisMailContainsUnwantedMimeParts: N

On 15 Sep 2021, at 9:43, Özkan KIRIK wrote:
> I'm using FreeBSD stable/12.
> I've tested this situation on stable/12 both 0f97f2a1857a (Jul 26
> 2021) and ebb3327d09ce (Sep 14) build.
>
> label $nr macro is works as expected for most of rules. But with the
> example below $nr macro was expanded incorrectly. Outputs are below.
>
> If you need, I can open a PR.
>
> # ifconfig -g lo
> lo0
>
> Experiment #1: The right output should be "ruleNo:2", but system
> expands as "ruleNo:257".
>
I can’t reproduce this, either on main or on stable/12.

Br,
Kristof