From nobody Mon Jun 12 19:32:57 2023
X-Original-To: perl@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qg20J6n73z4cs07
	for <perl@mlmmj.nyi.freebsd.org>; Mon, 12 Jun 2023 19:33:04 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from glebi.us (glebi.us [162.251.186.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 4Qg20H3Dv1z3xcK;
	Mon, 12 Jun 2023 19:33:03 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Authentication-Results: mx1.freebsd.org;
	dkim=none;
	spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org;
	dmarc=none
Received: by glebi.us (Postfix, from userid 1000)
	id 3B6BA3FF3F; Mon, 12 Jun 2023 12:32:57 -0700 (PDT)
Date: Mon, 12 Jun 2023 12:32:57 -0700
From: Gleb Smirnoff <glebius@freebsd.org>
To: "Zane C. Bowers-Hadley" <vvelox@vvelox.net>, wen@freebsd.org
Cc: perl@freebsd.org, olivier@freebsd.org
Subject: devel/p5-Sub-Quote: unneeded depends added in a5d9499c055a
Message-ID: <ZIdy6RlTOdlhbniW@FreeBSD.org>
List-Id: maintainer of a number of perl-related ports <freebsd-perl.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-perl
List-Help: <mailto:perl+help@freebsd.org>
List-Post: <mailto:perl@freebsd.org>
List-Subscribe: <mailto:perl+subscribe@freebsd.org>
List-Unsubscribe: <mailto:perl+unsubscribe@freebsd.org>
Sender: owner-freebsd-perl@freebsd.org
X-BeenThere: freebsd-perl@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spamd-Result: default: False [0.51 / 15.00];
	VIOLATED_DIRECT_SPF(3.50)[];
	NEURAL_HAM_MEDIUM(-1.00)[-1.000];
	NEURAL_HAM_LONG(-1.00)[-1.000];
	NEURAL_HAM_SHORT(-0.99)[-0.986];
	MIME_GOOD(-0.10)[text/plain];
	RCVD_NO_TLS_LAST(0.10)[];
	MLMMJ_DEST(0.00)[perl@freebsd.org];
	ARC_NA(0.00)[];
	R_DKIM_NA(0.00)[];
	FROM_EQ_ENVFROM(0.00)[];
	ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US];
	MIME_TRACE(0.00)[0:+];
	BLOCKLISTDE_FAIL(0.00)[162.251.186.162:server fail];
	TO_MATCH_ENVRCPT_SOME(0.00)[];
	R_SPF_SOFTFAIL(0.00)[~all:c];
	FROM_HAS_DN(0.00)[];
	FREEFALL_USER(0.00)[glebius];
	RCVD_COUNT_TWO(0.00)[2];
	RCPT_COUNT_THREE(0.00)[4];
	DMARC_NA(0.00)[freebsd.org];
	TO_DN_SOME(0.00)[];
	MID_RHS_MATCH_FROM(0.00)[]
X-Rspamd-Queue-Id: 4Qg20H3Dv1z3xcK
X-Spamd-Bar: /
X-ThisMailContainsUnwantedMimeParts: N

  Zane, Wen,

I think this change a5d9499c055a was incorrect. Sub-Quote shall not need XString with
any modern perl installation. This is the actual code:

  # if B is already loaded, just use its perlstring
  if ("$]" >= 5.008_000 && "$]" != 5.010_000 && defined &B::perlstring) {
    *_perlstring = \&B::perlstring;
  }
  # XString is smaller than B, so prefer to use it. Buggy until 0.003.
  elsif (eval { require XString; XString->VERSION(0.003) }) {
    *_perlstring = \&XString::perlstring;
  }

The B module is part of perl and is always present. Zane, can you please check
your environment where spamd failed? There is something wrong with the perl
installation there, I guess.

The change should be reverted, imho.

-- 
Gleb Smirnoff