From nobody Mon Jul 17 05:26:38 2023 X-Original-To: numerics@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R49YW4JMcz4n97w for ; Mon, 17 Jul 2023 05:26:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R49YW2qWtz3w85 for ; Mon, 17 Jul 2023 05:26:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689571599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DnkgxTqaSqaEIL45cV9HDQJ0LpnG1td6jGAjSZw2YFk=; b=AvfAsp8wcfjXf4PcISlyDOEfMmZSEjQR84Mt7Cf/0dirgEAfno/aEo8QTqU/1TH8/ubKor 5aLYZ7VhLS1vc1Hw4xllLIkDiXLKS7JnmM1cqOyNGke29SgPYAVeyfjSlzsCRQHe/aUQsz FXxboSItwNFMEufGfp7ReKVmkrc86EEv5l46hyZk2f7YqQUaqe06qWV6DBumPNlC+Sek6b Ivw7UUsczMSaETiWlNdxuQX5rvGFwnX8Tpos40O21jhLuAbFP8gE7PkwhVyCSnsKZAOk+E +pi/90r6s8hDajwAhY2Qa6H1eTjOrQObbFskO4Hdf3x4ynYc6kanZW6w2Ow4TQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689571599; a=rsa-sha256; cv=none; b=Es2Ymln5R5Isk6IUtv6vPmP+cp663LDo4rmq4igr3jBxcgsRL4kqbWBnJ05yI8FjzW9LxU 81zHsa5Ol5aIWcsVCyZs122IKmbPVptGMDCvsIzlVJnIjwRGRTPjt/l0AEm3y4pAqRxPCp 0blT65jILyfSy+cGvIP2bDnEO++6So/J/kW9jSRTe4xkNKkvwJ61adZnwxchcn89wut6JT N/5aocL7b3cqBORdIvGcelHO4Mb+W4u/LNXAqxK54C4IXF7kQ71E93PDUh927zb/qnN1MC 1rZY7+G3emrIT+6dWHp8OgwujZUmVUjHIgXrbQlESiNOiM1Oic5c+OgxDlmkpQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R49YW1Q5lz1BVT for ; Mon, 17 Jul 2023 05:26:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 36H5Qd0J000703 for ; Mon, 17 Jul 2023 05:26:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 36H5QdKR000702 for numerics@FreeBSD.org; Mon, 17 Jul 2023 05:26:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: numerics@FreeBSD.org Subject: [Bug 272539] cospi, sinpi and tanpi incorrectly test for NaN and Infinity Date: Mon, 17 Jul 2023 05:26:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: numerics@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions of high quality implementation of libm functions List-Archive: https://lists.freebsd.org/archives/freebsd-numerics List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-numerics@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272539 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbe4c7f273508994638b68d2fae742be37= d3cb117 commit be4c7f273508994638b68d2fae742be37d3cb117 Author: Steve Kargl AuthorDate: 2023-07-17 05:19:28 +0000 Commit: Konstantin Belousov CommitDate: 2023-07-17 05:23:27 +0000 libm: correctly test for for NaN and Infinity in sinpi(), cospi(), and tanpi() The current versions of lib/msun/src/s_cospi.c, s_sinpi.c and s_tanpi.c all exhibit the same defect. After checking for various numeric ranges, they check to see whether the input argument is a NaN or an Infinity. However, the code uses a value of 0x7f80000 instead of the correct value of 0x7ff00000. If you review s_cospif.c, s_sinpif.c, and s_tanpif.c, you will see that the equivalent statements in these functions are accurate and have appropriate source comments. The impact of these defects is to flag some valid input values as invalid and raise a pole error (divide by zero). Reported by: Paul Green PR: 272539 MFC after: 1 week lib/msun/src/s_cospi.c | 3 ++- lib/msun/src/s_sinpi.c | 3 ++- lib/msun/src/s_tanpi.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=