From nobody Wed Dec 15 01:45:36 2021 X-Original-To: freebsd-numerics@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 92F6E18E3619 for ; Wed, 15 Dec 2021 01:45:49 +0000 (UTC) (envelope-from enh@google.com) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDJ3x3WRfz4RJH for ; Wed, 15 Dec 2021 01:45:49 +0000 (UTC) (envelope-from enh@google.com) Received: by mail-lj1-x22c.google.com with SMTP id 13so30898527ljj.11 for ; Tue, 14 Dec 2021 17:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TypOQMGKOT7/gy+98iE98Pmk+W75A+ts4clAr8bmkaA=; b=BWmwHEeM6O+Zz9q6D+7GHQOK5fFVJRr9KGXvl+9azwcaWxqWI4Cgg8w7mf6o7pPBmy 9Qj67L3W8ThJpx16WiO9dEQu/5b5OXWTOPYZIkz0Jw4mWsatjTlTD9DUNn6qHyca6pdJ cyPjWi1hqWfK3q1F+DPB1RR9NgGpaMfIZaonR+T581jCvJ4eceIWWj59W3eEKDOMOf0B UxWseZUsr+0fNYowSg/CLeoEWM8UAKh5DDvblVRvqUKGLDKE1gRkEGkH2HOIVAdx4dSF 7JLe5fHLHzzkUVqu2Z2T0kt8Ypg0IBXDs4JWRENhIXe27G2TA/iKK7iE8AuIq2sRD+qz avwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TypOQMGKOT7/gy+98iE98Pmk+W75A+ts4clAr8bmkaA=; b=3czNBab0IZ2Z/bw37GsX18VeOWMagxtd+e/UM95/kUsj3Dh9LruN9D26L0TOnAZTt6 h4J09+aY2WHTG0/IgG6ALCASunavx8qZug+pzaYWnHHaHfZxY2ELQu8tPoKZd1nKCJR9 sZm/QnqNmILXFH9htgDOZ2PkgBsh6xsFKtuLnlYD34oUMUMYTjNmjgM+PfZrHUnVc795 TjT8sPyVnHkcCZ18e3dc0E8auAZ/Fu9ca7VnHOGE0HDoXUM8qSgOPbJXjJ2CFxUw+qRz DIGGeKjih83J65wUsvxsGlNv0wa1pNcozJr06D+g+7H1C4yIUywlICkhU7WDTprRY62N +BlA== X-Gm-Message-State: AOAM531lcvS9GI2o8VylD5yD2s2OaJfm4yHU+ClAozfX7UU3TX8NXJp/ pCiPzdrtaGJYZzW76qymdK4oLop+8hqsZA0wSTDhWw== X-Google-Smtp-Source: ABdhPJwtrqMNcKqJ0VcLqmIpQDyG83jfz3OBWAOiJCs8qOvk+AsQZrYymKXXdSRael9Dk43NwcmguzT7m5DbISgCS7E= X-Received: by 2002:a2e:904b:: with SMTP id n11mr7839651ljg.120.1639532747964; Tue, 14 Dec 2021 17:45:47 -0800 (PST) List-Id: Discussions of high quality implementation of libm functions List-Archive: https://lists.freebsd.org/archives/freebsd-numerics List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-numerics@freebsd.org MIME-Version: 1.0 References: <20211214200552.GA49922@troutmask.apl.washington.edu> In-Reply-To: Date: Tue, 14 Dec 2021 17:45:36 -0800 Message-ID: Subject: Re: s_sincosl.c: remove unused variable To: Dimitry Andric Cc: enh via freebsd-numerics , Steve Kargl , Michal Meloun Content-Type: multipart/alternative; boundary="0000000000000ad01b05d325778d" X-Rspamd-Queue-Id: 4JDJ3x3WRfz4RJH X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Reply-To: enh@google.com From: enh via freebsd-numerics X-Original-From: enh X-ThisMailContainsUnwantedMimeParts: Y --0000000000000ad01b05d325778d Content-Type: text/plain; charset="UTF-8" heh, no worries --- thanks to everyone here for maintaining the world's most-used (Android *and* iOS/macOS!) libm :-) On Tue, Dec 14, 2021 at 1:54 PM Dimitry Andric wrote: > On 14 Dec 2021, at 21:05, Steve Kargl > wrote: > > > > On Tue, Dec 14, 2021 at 11:06:53AM -0800, enh via freebsd-numerics wrote: > >> Newer versions of clang complain about this, and it seems genuinely > unneeded. > >> > >> It was in the original commit, and judging from that I think it's just > >> a copy & paste leftover from inlinine sinl() and cosl() --- the < > >> M_PI_4 case in sinl() needs the original sign. > > > > Yep. sgn is unneeded. Sorry about that. > > Thanks, committed in: > > https://cgit.freebsd.org/src/commit/?id=20d425842a4f80f9efc1de3f7a3b043435fe4b39 > > -Dimitry > > > --0000000000000ad01b05d325778d--