From nobody Thu Jan 09 17:06:46 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTWRC6TN7z5l7Zh for ; Thu, 09 Jan 2025 17:06:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTWRC57XYz4Scb for ; Thu, 9 Jan 2025 17:06:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736442407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SL2BAbs65tD8QmTS0q1fH+ykEBdF94KAQTqAraT3RqM=; b=xlgcylgwWW2H20dKFzZiLOv2mQxZZbwkV5Y2GcCmGLWb0qRtRzygb5CYaoYR4lbuhGk8BE fzrogFQvmPx0G8nxf/KNjxYJWB/zTJQpA7tfQi6y/bucZvN+o32VDAAHqP9kAl2ivtjUbq MzRu2qXxvofOC1wFfZmDaNN+er8vTKikRfoP6pMZgsFW2U26Lsx85pNpf9zFDLK2buXhUb 78n4P1hi+q2cMFxDqYh7HUIOIJh7xOtwLYbVwLw00AyoOez9CDAkaIaogErpfpn395cVtF PT+S3k2e7GAo66+OvQR5JXi53aBm/q7xUPcH6k6VvKVV8eZfdnWHViEg33dSWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736442407; a=rsa-sha256; cv=none; b=QjttaH+L75jaK9VZqEnKsoYplydY0SR8lxl6oLWE7zwWQVoPudaI2+SNVKgRFna+1NUWB9 SbinEJlRMKKK53yTa1b0CvXNgL1W0OspWOvxGa6YGowEGSIVgu5EVNeGgw1BTnd+Bcr1Ob cLycINPk5ZzoqVISG1QtQLoUjUHCbLbRCBpGTVS5pgk27u9wgSISgLDeEib4/dTb8TnRmh DczKqHaNoyMMBwrhZFF0qPrwnnvKibScnYk+RipLLPJv6FPmJjEsZFxeobAS7rZ2+9ny0y QjYbsKVEeOohRe01hl12JA1owycQ2GbspD5yuJUid9PkNbnKgIJfNRqWmPEaYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YTWRC4JcDzbSG for ; Thu, 09 Jan 2025 17:06:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 509H6lfh058168 for ; Thu, 9 Jan 2025 17:06:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 509H6lVp058167 for net@FreeBSD.org; Thu, 9 Jan 2025 17:06:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 282095] enic breaks when changing MTU on interfaces with fib other than 0 Date: Thu, 09 Jan 2025 17:06:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282095 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0acab8b3d1336d4db73a9946ef76b4bcd= 0b0aabe commit 0acab8b3d1336d4db73a9946ef76b4bcd0b0aabe Author: Doug Ambrisko AuthorDate: 2025-01-09 16:28:37 +0000 Commit: Doug Ambrisko CommitDate: 2025-01-09 16:52:54 +0000 enic(4): fix down/up, MTU changes and more ifconfig down/up cycles was not working. Fix that which is required to support MTU changes. Now doing ifconfig enic0 mtu 3000 for example works. If the MTU is changes in the VIC HW configuration, that is not reflected in and the OS reports the default 1500. I need to look at that but changing it via ifconfig works. So this is different then what Linux does. Change TX interrupt allocation to be in this driver. Change the admin interrupt count to 2. This make multiple queues work but need to be done as pairs so if the VIC has more TX or RX queues setup in the VIC configuration it will use the lesser value. While updating the TX interrupt also add support for devcmd2. Enable checksum offloading. PR: 282095 sys/dev/enic/cq_desc.h | 15 --- sys/dev/enic/enic.h | 76 ++++++-------- sys/dev/enic/enic_res.c | 4 +- sys/dev/enic/enic_res.h | 2 - sys/dev/enic/enic_txrx.c | 39 +++++-- sys/dev/enic/if_enic.c | 173 +++++++++++++++++++++++++++---- sys/dev/enic/vnic_cq.h | 5 +- sys/dev/enic/vnic_dev.c | 235 +++++++++++++++++++++++++++++++++++++--= ---- sys/dev/enic/vnic_dev.h | 8 +- sys/dev/enic/vnic_intr.c | 2 +- sys/dev/enic/vnic_intr.h | 2 +- sys/dev/enic/vnic_resource.h | 1 + sys/dev/enic/vnic_rq.c | 5 +- sys/dev/enic/vnic_rq.h | 1 - sys/dev/enic/vnic_rss.h | 5 - sys/dev/enic/vnic_wq.c | 104 ++++++++++++++++++- sys/dev/enic/vnic_wq.h | 18 +++- 17 files changed, 559 insertions(+), 136 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=