From nobody Thu Feb 20 16:47:41 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YzK1t3Xg6z5p7dN for ; Thu, 20 Feb 2025 16:47:46 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YzK1s32Bkz3bdw for ; Thu, 20 Feb 2025 16:47:45 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=UmAm3Bsy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f2e as permitted sender) smtp.mailfrom=markjdb@gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-6e67bc04a3bso11756156d6.3 for ; Thu, 20 Feb 2025 08:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740070064; x=1740674864; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=rbgClNlS8X4m0mp6JPXK/ojjx/9kavLks5Y51Qvteeo=; b=UmAm3Bsy+LIsdTOEg0w5NDFJe8MDioybtTOE8SOZAhfJh5N6nz2oj3NHvhwpM5KwNy SRXGfdicgrUVhod/yw3n4fwBvHWa25kJ4Zbz5TAzAzQvFGyi58dtEWKcAPibeY2cWhDw MRW/yi4W2ZO9guqV98NhugSDQhw/mXRoKTkolXEBwUISpBSgc/xlgif7dpz9GmYNhcnx IlufmR01Q0X0+X4xh4AY4PajG5MTfN7lOFIQgZabbouc7dzw0VW+4rO1XwrGORw16MWw 2sJiPsd/0RcJ3eT6pO8R35ZEG/MGVjCYZDOf9jZ+aHYQCjlH9pwldCzcR7H4/+rNXm/Z X1bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740070064; x=1740674864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rbgClNlS8X4m0mp6JPXK/ojjx/9kavLks5Y51Qvteeo=; b=aUh6c9O1QNLCSeozAZ0SN/Z3N4EQb46LkrHnI9vag6K/6tLhr4MLJ8MKeWu9cVen+p 4kU8caV38p9/P0EVei7wixnKksZK2iZ/WQKjj2OyFo7L4aRxFvsh3v6DpuPlAHaXrAb2 1W8v3NrBvsX+gCrq+W3nWFFjVkr7bniAMd2iKdPsaBdug/2cPgFLZ2LFFNKmOeiOt34W fWtSTwo12HAzW+sJHxB1vDmCYZVuYHXptPqq6AJQ8Ytf3JcxD5qmbPwphi8JnWl+k1aN cdsF4Pqo9EzEFwmS7dIABYjZChD4jjlNocCq/qQMDw3fziZ+ualEXK1lg/TqGj5MIm+I QHuA== X-Gm-Message-State: AOJu0Yz6GuL11eBncncZUuCfaa1LzjBJX1FJUtVTZ03GRDF1pgTXNCDn 0N8iQ1cuYSGyZlfexiGSi6P6tr9Cx9dneW15ZWfXptVqqPwHZP/6YgOGHA== X-Gm-Gg: ASbGncuXj61MurUGE8idAqClSH+gwDLoicrVs9GH9lIhdxQRAl6mEkEUNDeIHZtxPlU GqV65F7rZlz/L3wmcEJuLdWJvbrjTLsI67Imrn0OnlEJyIEEDeV5v3FmmRdwvalnoJ8stgk91cy 7f3lW0obhhtYNF9kswHwDyX2Cynf+YhojAcdKyvSEZIguHqtbuVMToDd1nCFi7vQm5egSJisiTA 4b3ce3ZFikk9F8yDlfCDzkhgs5obBLwUp64h6Q0ghWR1e7Tl0nC3VuaIRqjpLo8dvCYLd7wXDO4 eFrC+sPl2x3NPDpnshUCP0hGk4PwQA== X-Google-Smtp-Source: AGHT+IEQUMo3bDbuI77PFoy3ANrVzKCh31PjixHhtIHwJ4L0UV+3cbBB45FnjoQM3obXyZpwhGPi5g== X-Received: by 2002:a05:6214:300e:b0:6d8:846b:cd8d with SMTP id 6a1803df08f44-6e66cd06482mr285874276d6.30.1740070064519; Thu, 20 Feb 2025 08:47:44 -0800 (PST) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e65dafe946sm87365536d6.94.2025.02.20.08.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 08:47:44 -0800 (PST) Date: Thu, 20 Feb 2025 11:47:41 -0500 From: Mark Johnston To: Paul Vixie Cc: freebsd-net@freebsd.org, Santiago Martinez , Jamie Landeg-Jones Subject: Re: fibnum2.diff (Re: per-FIB socket binding) Message-ID: References: <7772475.EvYhyI6sBW@dhcp-151.access.rits.tisf.net> <38589000.XM6RcZxFsP@dhcp-151.access.rits.tisf.net> <2522290.jE0xQCEvom@localhost> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2522290.jE0xQCEvom@localhost> X-Spamd-Result: default: False [-2.59 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.989]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2e:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4YzK1s32Bkz3bdw X-Spamd-Bar: -- On Tue, Feb 18, 2025 at 05:16:07AM +0000, Paul Vixie wrote: > this is the second fibnum patch, which replaces (doesn't add to) the first. > some blanks/tabs/margins lint was incidentally fixed, a few comments were > added, the API of several existing functions was changed, and some wrappers > were added to others. as explained inline below, this handles both TCP and UDP > listeners now. i did not add an SO_FIB operator nor shim SO_SETFIB since those > are independent of this socket-related work, needed to get path symmetry for > shell-related listeners like sshd. The high-level changes seem to be: - If a TCP listening socket's FIB is 0, then the FIB of incoming connections matched to that socket will be the FIB of the interface on which the initial SYN was received. - When a socket is bound to a specific address, its FIB is set to the FIB of the interface which owns the address. The logic seems reasonable to me. The handling of the second point seems incomplete: it doesn't update the FIB number stored in the socket itself. Gleb and I talked a bit about eliminating that field entirely so that there's only one source of truth, and I think we'll eventually do that, but in the meantime, in_pcbbind() needs to update so_fibnum as well. > comments, questions, and especially testing results would be very welcome. This patch doesn't apply to main. Did you write it against stable/14?