From nobody Mon Feb 03 16:32:31 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YmsVK35FFz5m3C2 for ; Mon, 03 Feb 2025 16:32:41 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YmsVJ5rQpz3qjl; Mon, 03 Feb 2025 16:32:40 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738600360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v1qhfoH/AYTNZjm28o3Rqw0114N3y4GuuAGMU1iKcm8=; b=udGKLcdDCyYCDfIqe7L4UYQSJKj1vTMHneXf+wF4QgHZliFowr7gxaJpSu+xHl4LXnLLlp zhyNLXeXLwFBMvuuZj3uAL0GwEMBXkLBqkVNf19F2WkZqEBOwEq1h9NmR+I6VQ0gabjDHL RBqdxAqTNaurZXSkvbKNRB+qv4k3YNE4Rra10h7rQfVt1ZXYDE7Z79O7REgaqhm6Qc/9aE oBtaDtYszn399IqUQkv7o/sAClcNhKH81EraJY4UqRoRsNQKuOeIbbtxGsksneBnhWzs4b lM3AfJhR4B7nxZqnqbc7dcbDGBNZYMVhx22A5bAtutKV6YGAgJjCtICk95nwNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738600360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v1qhfoH/AYTNZjm28o3Rqw0114N3y4GuuAGMU1iKcm8=; b=rzA62XawMyHRYz32d2iSr3FCdGHy+Z8jdx9MJNr8tl7tKY6vL2CRtyGK8i0puhMFg+P+kx DRmTnw4rfIiXIVedAKOJ6tBein0jLEtbJDw06tFe0pZTMBNY6YDHl5pOClO53XkIPuzlsS w86P5aP4ZMMHcPrAbECy02EWJ1GvS8K/7SwkbDmk0TywJChXZa5sdUfdaQ4oeil5ORWDnE SAI697sn4B6mwMxLUpuQpBwTslkqqac/czfBSkjbh0fAfTIHZVcUDyEtXoMCI9t+cfYzQA ZRBoTQdrJ9BnjcijPulEbF02sEUjXKWnZJPET2YTAPu/ujC7kjD6kXLMALsTmg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738600360; a=rsa-sha256; cv=none; b=v+gL+1ln4rvoMDyCEwl2yaABbbyLghEWliwPTxHTpktgwr4fYgj+TZYc1m+UD627ikVTBn tiNoUtYH4o15yCL92EvIkaQvQTUxNFCQf3doIkhFXiWjtGSes9Eo3xDQEMCacmzzh+KbNN oKGBRGRzSXCYwIIm97F4gcgStFUW6SQUl+Mrx1Evh5QQdFpUlIeVw3QuRUzaWP7IAiD1HM ueEpUjLI/nG8bBklbwJpBuxIxBKc3mxrbNu30tcko5ZTNWnlbPvDgCb7z/Ij2N5NAsLJpT PZ0FIu24PwA7PJ/RTM+9TMOQLlQdU3kIvGQfPiyno7hMZGfWHY284SPOJTx6gw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2001:19f0:6001:9db:98f0:9fe0:3545:10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YmsVH5r9Qz1HPG; Mon, 03 Feb 2025 16:32:39 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: <57B63ECF-F2A2-43FB-8814-B2BDF7CEB9F4@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D" List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: Any real usage of sppp(4) on architectures other than i386 or amd64 ? Date: Tue, 4 Feb 2025 00:32:31 +0800 In-Reply-To: Cc: FreeBSD Net To: Gleb Smirnoff References: <0DC91E3B-DDB4-43ED-866E-3DA02BBA1241@FreeBSD.org> X-Mailer: Apple Mail (2.3696.120.41.1.10) --Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jan 15, 2025, at 4:31 AM, Gleb Smirnoff = wrote: >=20 > On Tue, Jan 14, 2025 at 07:25:26PM +0800, Zhenlei Huang wrote: > Z> I just fixed one long standing bug of sppp(4) [1]. During the = testing I found ng_sppp(4) depends on this module. Unfortunately sppp(4) = is only enabled on i386 and amd64 by default but ng_sppp(4) is enabled = on all architectures. So on architectures other than i386 and amd64 = `kldload ng_sppp` will never succeed. > Z>=20 > Z> I suppose sppp(4) is rarely used nowadays so I'm planing to = conditionally build ng_sppp(4) only on i386 and amd64. Is there still = real usage of sppp(4) on other architectures ? > Z>=20 > Z> 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D173002 >=20 > I would claim there is no usage of neither sppp(4) nor ng_sppp(4) on = any > architecture in a very long term. Last time I run this kind of = network framing > in 2004 and in that times the right way to do it was either pure = negraph(4) > graph based on ng_cisco(4) or ports/net/mpd + ng_ppp(4). >=20 > Don't waste your time on this code. This is a quick simple fix. Committed as = https://cgit.freebsd.org/src/commit/?h=3Dstable/13&id=3D29f77be0d844aa7e9b= 26fed8b550e12ad504b4d2 = . >=20 > --=20 > Gleb Smirnoff --Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Jan 15, 2025, at 4:31 AM, Gleb Smirnoff <glebius@freebsd.org>= wrote:

On Tue, Jan 14, 2025 at 07:25:26PM +0800, Zhenlei Huang = wrote:
Z> I just fixed one long standing bug of sppp(4) = [1]. During the testing I found ng_sppp(4) depends on this module. = Unfortunately sppp(4) is only enabled on i386 and amd64 by default but = ng_sppp(4) is enabled on all architectures. So on architectures other = than i386 and amd64 `kldload ng_sppp` will never succeed.
Z>
Z> I suppose sppp(4) is rarely used = nowadays so I'm planing to conditionally build ng_sppp(4) only on i386 = and amd64. Is there still real usage of sppp(4) on other architectures = ?
Z>
Z> 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D173002<= br class=3D"">
I would claim there is no usage of neither = sppp(4) nor ng_sppp(4) on any
architecture in a very long = term.  Last time I run this kind of network framing
in = 2004 and in that times the right way to do it was either pure = negraph(4)
graph based on ng_cisco(4) or ports/net/mpd + = ng_ppp(4).

Don't waste your time on this = code.

This is a quick simple fix.


--
Gleb Smirnoff


= --Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D--