From nobody Thu Sep 19 13:04:58 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8bMw6F8kz5WZ1v for ; Thu, 19 Sep 2024 13:05:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8bMw1yT5z3x0K for ; Thu, 19 Sep 2024 13:05:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726751100; a=rsa-sha256; cv=none; b=SsE6gMhXYZj0yoE+M1X1obRa4bk+szgjB74kevcuTBMPmGIHX4uf1s2d/Mu7QTmwnfPKkc j2TOPKEmjTnaEH3p2J2ym60Scse4zkfACCx0m6wa3zJYoz4sSWsjk5eJs1N6+jZbcojIx9 DLXE3WLLQLJlSUWMJmGIbuD+0/Zh+aqftn7+tQRyD6J9rMICUOKrTOkkU0iDmFN/saWoTW AnQqzhO6U5vjsoE0Wl0vFlD3hiQqEfroLhH+s/v01XwmGbdxCHAwQVTDS3TeZhChyvMc8K 2iG5Xcoq4B8unf9xBdV66ZyOaQS7Hh48MRIAeLWZgHFGg/j6T+RYkDZD/PrMUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726751100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rr5R9W/hwvBDn9lbBfmcpKypJuP9daZSTXutGLD4AqM=; b=o1e7yCuO4+qRACfMChax2ic/th40xHR4SnBYjMequqqR/slHqjGPrTBbbLxXSql0tycdmj tQkkmQlBFP4cWbo6p2TFiQ1i6NMIL5DUAB4FZJvN0F+V0Oc8rsTAEb+j7ERzbdR6Nzh3bE Q0IfPO6rv0HEGXYLb4lMxqoKh1aIDLlRV4Za4DTuxqEgTf1fE5f2k+885beE87jJtoQYIW emTazGRnd6scYij/0ksmLfqNbgvn3Ct4GcnjxmeFqzfeJ0PNz5H3qJxDzEgNpv89yOcxiT 0LfoCuUccfTFyxMB/2O0lgz2dwEMD7bjtmGtSMZdMOXvBT3OjYjxWE+QlZxfkQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X8bMv6qZCz16Yp for ; Thu, 19 Sep 2024 13:04:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48JD4xln087631 for ; Thu, 19 Sep 2024 13:04:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48JD4xrZ087630 for net@FreeBSD.org; Thu, 19 Sep 2024 13:04:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Thu, 19 Sep 2024 13:04:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #94 from commit-hook@FreeBSD.org --- A commit in branch releng/13.3 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D36265a707dc51189843498e059361010e= a3c9718 commit 36265a707dc51189843498e059361010ea3c9718 Author: Kristof Provost AuthorDate: 2024-08-14 09:29:30 +0000 Commit: Mark Johnston CommitDate: 2024-09-19 13:00:48 +0000 pf: invert direction for inner icmp state lookups (e.g. traceroute with icmp) ok henning, jsing Also extend the test case to cover this scenario. Approved by: so Security: FreeBSD-EN-24:16.pf PR: 280701 Obtained from: OpenBSD MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 89f6723288b0d27d3f14f93e6e83f672fa2b8aca) (cherry picked from commit 5f3f07397a7909e8f9449d1aa0b465159cbf0d60) sys/netpfil/pf/pf.c | 21 +++++++++++---------- tests/sys/netpfil/pf/icmp.sh | 4 +++- tests/sys/netpfil/pf/icmp6.sh | 4 +++- 3 files changed, 17 insertions(+), 12 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=