From nobody Thu Sep 19 13:04:47 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8bMg6XfRz5WYvd for ; Thu, 19 Sep 2024 13:04:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8bMg4Rs6z3wZs for ; Thu, 19 Sep 2024 13:04:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726751087; a=rsa-sha256; cv=none; b=EGaNxI0iMtKDWbIJ//9XzhJRZIErVRtH/D/syGwBBZYA4GmwaVI5dZbv9RH7KeER89+Xik l2KLijLHzwA73D4ZOrkfj8/gDqOAigXVPwFgUqkRSD4DXb0RGaPp5kclaoUkr5KN0x3LUi 9xXTk3KW7aCyxvyGaCQkpnmMtXUD/en5YxyMg9NFtrPrp+Yqc5SSQUv2Fm4JVKMdQvDPhG csBy3A4+VQheYnarim+N+CTsnf+6Lpw+MZR/ObrwzcMfbTnwje2RbK0UAt7fDfBb4AK0zY 88LBEdqZxY08qIgc8Xl5Trpesi2vxYoLp6L7NoqT2p67+I+EdqhQLtZbxjNS7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726751087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PX32V/3R/bjH1jBNtubA0Rfu35+pfrOk4fHIFtyjUFM=; b=HMdNEzoX1XKPG2iIsNI2xLihcxpHk7vBA0pgw4JxPpEL8MRI+QrP1miimcz0TDX4PpWmBJ ZzqkZR0nOnTwoj8JeKbklFfJKVxrQ8KQDzAVlIwA04L1lcKU5VSsLL5SWIX49hu9bqKhWK s0NW5p9aIhWpr+KfAXgtQzZYYwYI7LWSWgMbj1vx4MCzBIhwAZN79eN1U33wXo9A3pQhw0 OLXxZXRoBpP1hUhmaKBHfTHaOwNjD8ZHTNCqphZg/iUEl67FBYGaP73/RiYmlizIWgoSk7 HhGK93wTmRFrZ0mBbBDmzc+fs+PUilSHPRDpH7JoPHWq4Em8yIyccNYOV+onnA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X8bMg3F65z168g for ; Thu, 19 Sep 2024 13:04:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48JD4lUW087016 for ; Thu, 19 Sep 2024 13:04:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48JD4lfW087015 for net@FreeBSD.org; Thu, 19 Sep 2024 13:04:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Thu, 19 Sep 2024 13:04:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #90 from commit-hook@FreeBSD.org --- A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D9481d7a260822d20d60d582bfff20bdd7= 54c49c5 commit 9481d7a260822d20d60d582bfff20bdd754c49c5 Author: Kristof Provost AuthorDate: 2024-08-14 09:29:30 +0000 Commit: Mark Johnston CommitDate: 2024-09-19 12:58:15 +0000 pf: invert direction for inner icmp state lookups (e.g. traceroute with icmp) ok henning, jsing Also extend the test case to cover this scenario. Approved by: so Security: FreeBSD-EN-24:16.pf PR: 280701 Obtained from: OpenBSD MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 89f6723288b0d27d3f14f93e6e83f672fa2b8aca) (cherry picked from commit 46c4fc50d3012ca3c8756df243589add36b70830) sys/netpfil/pf/pf.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=