From nobody Thu Sep 05 07:36:17 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WzrlD4jg9z5VX4c for ; Thu, 05 Sep 2024 07:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WzrlD34W0z4YmL for ; Thu, 5 Sep 2024 07:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725521784; a=rsa-sha256; cv=none; b=lRZVJLAGDcFf7oBTIEc9YDC/4fkS1KsThfJaZ8x3wCcFg+d1v5PgNtkxBMm7U9nA/NLY5T fiTzKvQMgH2VCtC1Mzhn9AnBiXJrbT+BroMBhDUPK696k9JQgUZDtU6dod42zMBqNG3x5U Ed1V5EJVjhCriYkQzwCBzSqJBFm8mWQN7BKfbxXSg5KEojrw0lZLgP1MPaOVoQX/+66jTy 7AjWkx1d21oodIdKC5sjUow5LtfB8WySvp25dLlMe+gbcrZMdAsRS+GeDAh0flnCDrD/24 fYBA8+HQE4mbuKtp1w+YsKHXm0prhH/g6sX8w/BgVVDeGtjpj4gIAA6tXS807w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725521784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bvNlEJc/74q4MgTK/1qb+MoepVBgO3Lsrwrhasiph8Y=; b=qf3KxZg4Juy0W8vFBkpHGJbLzlziDOK+VIj4ew9zP4hTy8o1x/tH11GZKOTrLTIGl5PxPA 9EkWVhboeorhWnC9ndYrQL1owBqWu9IyXw/960GO5dlIJYgoJFd/K39zTOdrvOULqNuA5H myzVzqtVlltCZi8gRJYEONEw6rdPOK4AqvCeGrr8tL75aeksqE4Rw1+PQKbIXQyWtPq958 UCn3X2OM8eM25HLG1qH/aRGbjD7hO89XV/t92XwnY5h3/azyB9ZLejPbqgvHy6+XOs2fYH 2aKRDdqeCppAGaHr7OnwGBp+a5sDVJlpBEUDmpNkZjJdFN442bDDn4oA1fOFuw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WzrlD2bfcz10QX for ; Thu, 5 Sep 2024 07:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4857aOJB061852 for ; Thu, 5 Sep 2024 07:36:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4857aOxL061850 for net@FreeBSD.org; Thu, 5 Sep 2024 07:36:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Thu, 05 Sep 2024 07:36:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #79 from commit-hook@FreeBSD.org --- A commit in branch releng/13.4 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd3ee2188686dce00083ba382c1a773d4e= 293b242 commit d3ee2188686dce00083ba382c1a773d4e293b242 Author: Kristof Provost AuthorDate: 2024-08-26 12:59:38 +0000 Commit: Kristof Provost CommitDate: 2024-09-05 07:34:26 +0000 pf: improve the ICMPv6 direction check Following bluhm's advice this changes the way we setup state keys and perform state lookups for ICMPv6 Neighbor Discovery packets: - replace the NS-dst with ND target address; - replace the NA-src with ND target address; - replace the NA-dst with unspecified address if it is a multicast. This allows pf to match Address Resolution, Neighbor Unreachability Detection and Duplicate Address Detection packets to the corresponding states without the need to create new ones or match unrelated ones. As a side effect we're doing now one state table lookup for ND packets instead of two. Fixes a bug uncovered by one of the previous commits that virtually breaks IPv6 connectivity after few minutes of use. ok stsp henning, with and ok bluhm PR: 280701 MFC after: 1 week Obtained from: OpenBSD, mikeb , 2633ae8c4c8a Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 5ab1e5f7e5585558a73b723f07528977a82cee82) (cherry picked from commit b84344206721ed2803d5da68585289d5880efe3f) Approved-by: re (cperciva) sys/net/pfvar.h | 2 +- sys/netpfil/pf/pf.c | 116 ++++++++++++++++++++++++++++++++++-----------= ---- sys/netpfil/pf/pf_lb.c | 2 +- 3 files changed, 84 insertions(+), 36 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=