From nobody Tue Sep 03 18:30:38 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WyvM670KPz5TkY8 for ; Tue, 03 Sep 2024 18:30:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WyvM65w63z4QgD for ; Tue, 3 Sep 2024 18:30:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725388242; a=rsa-sha256; cv=none; b=MFIy7VSVZQJTBBlt2UpED66+/MGQU4/qEkix7kAfAyESAx4QJIwNpQP6cflk+K9wahsVWS ggpXk9ye2ldKvqRQSGRMyGkCPbKoW6ApVx7nfJCSExkN+XCInjiboKMIWIl2beXy5ENsTE FGzbJsBujAJaB6TstBq1yRkPE0Gx6N5M8bsu8WRYEr2A9lAe4tMYrRuFI5nn23Jpii1EIY us24gsEI0L77nbswbdDLgrycMl4LaKfpqJX+PHFfPR1r6T80JjDKG1nxTX3p9bnXP3WqDk pBbMyeGV0AUkMlpfcSluleD7pyjt9fHChdJ0yXkl46OJj4juEev+nmvYyr3mYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725388242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zGJo1crcc8kQ5XXFc7QOm2AhkR7qSpkeBh3Qad0Q8CQ=; b=obvFY115S/V0gbaCWt+ePNF8k6Pu6lmfInI3bz2ejWF4ODZj55FLD0GnqvK+sfXXBvJexL 6pmbcu8JGkgiW4ReRLe051RS6+skZrdF1u3S+4YwTbEU4OeKF1lF/Bg92drRcheDJ/nHrW 8M77MNvfH1s10+U5cjqujCHHK+yGffxPtE0cCndC80oTuBdu3A3sxo7NA6ScclTjvZa6GV AbEQ7UeVq9eOSEUXNjeMiTp7CjfM69F8qtY/ojkv9EcmK4svp3dnbg+qYEreZFjEp0dsaH WfJrqu9vAVTbmcRSCBfv2Dlk8YnozaBye7qtGzRANR6eDamNRX7+YawURh7HcQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WyvM65XLbzrYZ for ; Tue, 3 Sep 2024 18:30:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 483IUgLm022301 for ; Tue, 3 Sep 2024 18:30:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 483IUgtA022300 for net@FreeBSD.org; Tue, 3 Sep 2024 18:30:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Tue, 03 Sep 2024 18:30:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #67 from Franco Fichtner --- There are some open release engineering questions in this thread, lack of professionalism discarding a problem that was later fixed without comment aside. Doing the least bit of rectifying the previous behaviour would be a = good start to a useful discussion on the subject. The first and foremost question is how this was tested and verified? Was the researcher involved in all steps? The commits don't have a "Reviewed by" or "Tested by" either. Is this normal now? Does release engineering not assess the risk of spreading an SA fix over 4 commits with about 500 LOC changed introducing new features while at it? Th= at then grew to 6 commits, with 10 commits at the moment. It's a classic scope creep that should be avoided on releases at all cost. The test coverage was= n't there to make an educated choice either. Why is the fake id portion of the original OpenBSD patch omitted? At least https://github.com/openbsd/src/commit/49f39043a02d is still missin= g. Can anyone comment on why one would think that we should try to get away wi= th the least bit of commits here when we can clearly see all the related probl= ems were seen and handled in OpenBSD in the meantime? Why does nobody ask the reporters here to test this again? Why are the insi= ghts given by reporters brushed off? You can clearly see where the problem started given that nobody cares answe= ring these questions. TLDR: SO should do this again, please, but RE shouldn't. Cheers, Franco --=20 You are receiving this mail because: You are the assignee for the bug.=