From nobody Wed Nov 13 15:48:14 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XpSNt5YlDz5dkyc for ; Wed, 13 Nov 2024 15:48:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XpSNt4VWTz4y2x for ; Wed, 13 Nov 2024 15:48:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731512894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+4TjI+rVH5bhuUQ57+khpOqWdZECdEfc4/adjUYEYBA=; b=N1GobuQPbQ8rosSbC4NKcKk96ldfKkyIEVhr5b/WJc6cdFCiwKUFDdMcWVfgw+Fsr4JzBF efiTx0OhVRrBWD91bo28r/Y3OlAbVxp0CxHjduPZypR93JmIJx3PTcMXZMtp2t9XkrS8p2 Q9vbIPgeUblC6tH9BODWwcz636afBAiP07bsbocSTvIxzfkrO7qY5F0Gzb9aRGWV5uY90D asiEDPIjmL32/d5ocf04sD4SVPfHkKEXDF4KpMeYHh7S5ZO9+4PTPQuwdJo4/CR9rf7I61 /f3KAgFprLScV27YfS4D1fkC4A1nzFDmB/jS6pQSxgxmrMY+4rGrHpFlbW8rGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731512894; a=rsa-sha256; cv=none; b=MzIVwGJFdikeLs1d595gUeS8hGnauOaManoOW4qntTQ8X2PCRRq/b8KHVL4ol6fTTZ05J1 bh8ghBtZhAQ5DtOR2cK5gI00+454q26jFuTdyG5BmDbuRKXcMmU6jvcuHoSPTZeI559G39 f/G41OY/zCyAvWgh2L7+cZ0+zaOvtrXc4gY6Ay+UBkBQnrI7XGVHFFswM8jp5V4ZCAQsOM Fcn2eBB/NlcXjRJ+J26oPTSRve66jblvnmUzFVUhBtWQ6uuY7Zwfyhl2tispptigFclYvv 4doS/Fa0MKlkYtXmBU+st0zFLh/CWkDRJTD32/7vvJECrz0tyVhKwFCe+KM7wA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XpSNt400Xz10nf for ; Wed, 13 Nov 2024 15:48:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4ADFmEe5012508 for ; Wed, 13 Nov 2024 15:48:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4ADFmEUP012507 for net@FreeBSD.org; Wed, 13 Nov 2024 15:48:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 255309] ice(4) driver doesn't use RSS option correctly Date: Wed, 13 Nov 2024 15:48:14 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mhorne@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255309 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D23173329b096499f818adaa35255c033e= 9ee78bc commit 23173329b096499f818adaa35255c033e9ee78bc Author: Brian Poole AuthorDate: 2024-10-11 19:57:52 +0000 Commit: Mitchell Horne CommitDate: 2024-11-13 15:47:28 +0000 ice(4): properly use kernel option RSS Header ice_rss.h uses the kernel RSS interface if option RSS is defined. However when ice_rss.h is included by ice_lib.h there is no prior inclusion of ice_opts.h to set RSS causing ifdef RSS to always fail. Add ice_opts.h to the top of ice_lib.h (like ice_iflib.h) so RSS can be defined when ice_rss.h is parsed. With that in place, compilation fails due to a missing defintion of ICE_DEFAULT_RSS_HASH_CONFIG. It is defined in ice_rss.h only when RSS is not defined. Since this define is not part of the kernel RSS interface but ice-specific, it should always be defined. Move its definition outside of ifdef RSS. PR: 255309 Reviewed by: mhorne, erj (earlier version) MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1460 (cherry picked from commit 6e5650896fe47398e49e3d81af60cc60dbb09e6e) sys/dev/ice/ice_lib.h | 3 +++ sys/dev/ice/ice_rss.h | 16 ++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=