From nobody Sat Nov 02 15:51:46 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xgj0325t4z5cFM3 for ; Sat, 02 Nov 2024 15:51:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xgj024xX1z4HZc for ; Sat, 2 Nov 2024 15:51:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730562706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpziugJScxEjCw+JQ1JDLi/tmctOYOMwTABEZLtj+ME=; b=rEHk0S06lTDF6VfEVkhHir/qlwPRjYSSkpFNN2GMwHJJlIFDgf6bUe8aknUXchmhAaO2/n KzCGtD1L8LOThzCl5rOqtZeCQQN0Cy+Ga0OAGY4zBey5Q1tOiYTfEb7u2EB3dcbi3adfXz AQlpyPBey4ep4d0Kxv6lS8DzXdqE1H+zkk1vvmiNJpkE4NbVDGrNGiaP2+03IdgrKMLKYV g/uZT7PwRE9gJTSmnAPk81l3QQLuRgUv+mQ87ZJoDqYnquw65HWFpOJxihvYr+19k4kCuW RVFCjnpM3i0/P34cg0GrsIVmkCmFCfDZL1e5nj8GXzXZ/NrGHyM4seODJvijUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730562706; a=rsa-sha256; cv=none; b=R6Fxb24TLTiPaKdDHN3kQfA6irkQ034c6yr2fBRsWAFIBMcYt/y86Jm2/xdyyidwsEdac2 Ul+y6P8DD+0ZmiNbyV1ErpPUuQIJAnL+gndtXXZuh3pzKwPPLsPAtvU9BPYNwlRILZ9eBS 7YoJ1ZiZJFwH8R7jzjvh5KZF7KbQZXKVBIyvKRO5EjxlFn3EnFagsmhypBdxtrWcMZsIQ2 D9lI9Nd2PYVugAyex6iugya9+O5dd0WKT8fkXFmYpbi+gKFGjAz4LRzlFPlFwq9zkgYyEu UJIdcvUBEC6On84dLGtOSjG6EoW1WcwxjeD45jlhhBZrX2gs9Dtk/GtGcPbKJw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xgj024MSWz19d4 for ; Sat, 2 Nov 2024 15:51:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4A2FpkNx043801 for ; Sat, 2 Nov 2024 15:51:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4A2FpkgJ043800 for net@FreeBSD.org; Sat, 2 Nov 2024 15:51:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 282478] [ipfilter] Silence a lock upon service stop Date: Sat, 02 Nov 2024 15:51:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282478 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |markj@FreeBSD.org --- Comment #1 from Mark Johnston --- To fix this, I think it'd be sufficient to: 1. Use callout_init_rw() to initialize ipf_slow_ch, and remove the locking = in ipf_timer_func(). 2. Use callout_stop() instead of callout_drain(). This assumes that the global ipf lock is not dropped while executing ipf_timer_func(), which I believe is the case. If so, then callout_stop() = can cancel a pending callout without sleeping, avoiding the problem which trigg= ers that warning. --=20 You are receiving this mail because: You are the assignee for the bug.=