From nobody Tue Jan 30 05:39:47 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TPDWl3dWmz58L1l for ; Tue, 30 Jan 2024 05:39:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPDWl1tM3z4Wk4 for ; Tue, 30 Jan 2024 05:39:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706593187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WfLTZRcRoAsgCkT7EV1iRFptvBvMjlo0Vzvg5J2atak=; b=OpPx1XmaV9PCDfsPIknVZqW8IkZfprZiOsrK6SfYtU8dM0ObMfH3RdsAUNGi5m7BR+7bOn RwF/TThUjB0cPGHyao7cRNSBNYpj+CFjRUBVHLe2wk5WdobckNWqz0OFw/Fb6E2QhrRVwh ELOCz6WaJ+p58t6yDOzlxkIMF3xmK0hrWSMA4ar83MbNhtmKPx4uqffTBjT2Ur7wuyZLV9 Kqbn5D9/kPesJxDG4VnyJDbGcUGKZhQnR9VlmB+dlSMFE18F/W08N1TCpTXyxq2usgssYO 8hE4L6NiVicxDzeHZj0YmLjZKQgWZM/vFdcSYpwWDBtLMy0Zmmb46lFqKSb1TA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706593187; a=rsa-sha256; cv=none; b=S0xiYmDdZszo+ql0ZbcLO1R1BIqbOJ9cMfp/5yXAAy44ZWVZBr3+fW0Br4hlEQ35zie3nh 6fn7eJRxga7z8QTxFqKf6vb61sB5iR4DuoZUNcFBaT8LTZfs1pDVvZe24dCieUDzRS1uGz S/VmZ46UGk2M5lyiRxNk23ct4lSsDH6TzNNaxCukssdILxippyP7kz/nbNRu4ETwIoWPXP sR5uI0pDy7/e6q4C9FCLURp3r/0hnlG6w2odk+RoMorA2quCX9saKACJnSeQLKZWZ5uVi1 76aF6NlIQcVvTmqgYrLnEsEE/glhHkDk9jujsr8BVng+JaAJheNacje2Wj9pRg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TPDWl0Z4pzN64 for ; Tue, 30 Jan 2024 05:39:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40U5dl7Y062632 for ; Tue, 30 Jan 2024 05:39:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40U5dlel062631 for net@FreeBSD.org; Tue, 30 Jan 2024 05:39:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 276363] if_wg: Fix bug in calculate_padding() for the 'p_mtu = 0' case Date: Tue, 30 Jan 2024 05:39:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13? mfc-stable12- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276363 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D86986d381072171a5d6183701ae2f96c2= d9a6406 commit 86986d381072171a5d6183701ae2f96c2d9a6406 Author: Aaron LI AuthorDate: 2024-01-17 23:29:23 +0000 Commit: Kyle Evans CommitDate: 2024-01-30 05:37:29 +0000 if_wg: fix erroneous calculation in calculate_padding() for p_mtu =3D= =3D 0 In practice this is harmless; only keepalive packets may realistically = have p_mtu =3D=3D 0, and they'll also have no payload so the math works out = the same either way. Still, let's prefer technical accuracy and calculate the amount of padding needed rather than the padded length... PR: 276363 (cherry picked from commit b891f61ef538a4e9b4658b4b756635c8036a5788) sys/dev/wg/if_wg.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=