From nobody Wed Jan 17 23:30:57 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TFhvj6DWHz572sF for ; Wed, 17 Jan 2024 23:30:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TFhvj58k4z4LLQ for ; Wed, 17 Jan 2024 23:30:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705534257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9b3f1gPLfII1ukOElCZNCbqc/+wm5yB1+Pq6Ln8c/Sk=; b=qK1b3Uwa4HDBOfCmoOIe68F8Hjy2ZtfpDS/w4pk9lvM4KoASqnWoqmVEfCKIfJmhE3bpGK CORk3oJU6s2ChU4GSlfGILFGhD7iKxa05LUxQOjjx2H9ZStALYE8STSLGUNfT8lqAuhuNk 2PY3n3rpBYl+otrcnLBbNrisla58FDLMA+lWi29ETDdVCidaF7WV1feXt9oHx5vVEeYFV2 do8e4nhXUeXKGyo+MNrVpP+yBZZMOJFg88d+Ty5AHm6155V0m9ltIWKsF2tspjpEABrj4+ VKAwlTeBdXaLzTMo0riEW8ak++n2w62GGllR04YLNajzyPAMNKbdZDblsrfyFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705534257; a=rsa-sha256; cv=none; b=pRjxpSLIjz+bQ64wM0qrZGqMkzdSCC7ZdBYLE6oDskOQPr2CXVJrdK7NcoN5E+PguEi93w YnSi4z6adsTh+J/PcxR6RyDsKUrrYUYQw4wdHyHDfVK3eb7NxOJel186e5IMgwF+4PKtST KGPh/ovHNMFe16IiAD0rt6+BvYLB7zS99EkMiyIbfPPzsDIt5ZPZiaaby7/gmJhYhT9ZYd Hzjp8hkzLGEw0sV6zOlqelF+XaS2qSPZwobP6cx8Vxx8UWGosMC7+UA22CId1arsTcDJnb vLuivQy3q3axsadOtQNmMmW2P45iu5/Nf+9xJsz68Jz4gi8Db4zm9t72uy+iLw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TFhvj4FFTzjjD for ; Wed, 17 Jan 2024 23:30:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40HNUvrG025604 for ; Wed, 17 Jan 2024 23:30:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40HNUvH5025603 for net@FreeBSD.org; Wed, 17 Jan 2024 23:30:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 276392] if_wg: Fix noise_remote_alloc() to acquire 'l_identity_lock' lock Date: Wed, 17 Jan 2024 23:30:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276392 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D7a4d1d1df0b2e369adcb32aea9ef8c180= f885751 commit 7a4d1d1df0b2e369adcb32aea9ef8c180f885751 Author: Aaron LI AuthorDate: 2024-01-17 23:29:23 +0000 Commit: Kyle Evans CommitDate: 2024-01-17 23:29:54 +0000 if_wg: fix access to noise_local->l_has_identity and l_private These members are protected by the identity lock, so rlock it in noise_remote_alloc() and then assert that we have it held to some extent in noise_precompute_ss(). PR: 276392 sys/dev/wg/wg_noise.c | 4 ++++ 1 file changed, 4 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=